From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66D0DC433E9 for ; Mon, 8 Mar 2021 19:30:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3F390652B2 for ; Mon, 8 Mar 2021 19:30:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231153AbhCHT3p (ORCPT ); Mon, 8 Mar 2021 14:29:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230075AbhCHT3K (ORCPT ); Mon, 8 Mar 2021 14:29:10 -0500 Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF851C06174A for ; Mon, 8 Mar 2021 11:29:10 -0800 (PST) Received: by mail-pl1-x62c.google.com with SMTP id u11so5329609plg.13 for ; Mon, 08 Mar 2021 11:29:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=sLA4El8vUKSqbUUkrvUDv5c9ZEn5CZGnocmZoe+le6w=; b=Kd80LMyv/PtYZ/89LtQkMyjx1ua/BVaNSsUlLnPUBY+x45P29JUvbnSFIQ8ekqH/S4 dop6sG4RMLkBqGZKO1qmPPoaeQ6TnW5WpCQlPwLxzpnf84KWdbO1j23B2HPzcNdWNIcQ nVAaoM7kq8uAgYu1EnQGNIoyIwdSRXDWwwJAdtsX29wE20KFPiIA0WLQceKHWMesYapO 43ki6+lW0R7R1z2OiYm2XyZBqNP1FCoo8baF6jH84s6sFbWl4YSKmd+p0nTpkQbXzx/s gZmPmIeI6Izsp73okFLNIQLZJ8GgNiPwmAGmLkWEcKA0ZNxsndp9M8KrX0NakCbIrlLe tF8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=sLA4El8vUKSqbUUkrvUDv5c9ZEn5CZGnocmZoe+le6w=; b=OQE09e+kydLcLa9kECCZbq5B+JlwTtrRQlzotKbxRFbqULbuRjwEUUq5B3I76dd8Am Y/wWcfRVKjRaLr6A0wLpwaW4G7QAmzIHQEjck8J46X6lVDBcoLNNt1wb2+uXv4vPJ4IV 6TSUkVmexRHL56rYbrYTosOUN7M0UCMVpC6ekgD8WMLlPctin+DrFeJ5sjJnvEQ2k68n 68TLg17eTx72gPMcERMDmkYfLZA8eAm3tMKAKI0TcZ8fTyfS49QcIkadrV8zo1S02ZzK RC4Z/SZLWsCiuS33ta4gaYJ4JgUc0VWH5X6kkltgBxTCv095HdyTyUg5a5LijwgROxrA XfJQ== X-Gm-Message-State: AOAM533YX+h9it4YoKVydujYPHygJMidpgE8Ni0qBVUhyJFplr3ppRGX Y4DnOpdZngeMsc88W0lbtL0= X-Google-Smtp-Source: ABdhPJzljhuswDOR6anCcs2yujE3U4+zKzUNVc5RFBcKfECrmHoYHSBvWKyuDP3dvy0EOBoXMt6Guw== X-Received: by 2002:a17:90a:8408:: with SMTP id j8mr436398pjn.1.1615231750268; Mon, 08 Mar 2021 11:29:10 -0800 (PST) Received: from google.com ([2620:15c:202:201:39e0:7b5c:9fa7:f6e0]) by smtp.gmail.com with ESMTPSA id k4sm11082447pfg.102.2021.03.08.11.29.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Mar 2021 11:29:09 -0800 (PST) Date: Mon, 8 Mar 2021 11:29:06 -0800 From: Dmitry Torokhov To: Andy Shevchenko Cc: linux-input Subject: Re: [PATCH v1 1/2] Input: tsc2007 - convert to GPIO descriptors Message-ID: References: <20210307220549.354263-1-andy.shevchenko@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Mon, Mar 08, 2021 at 11:10:38AM +0200, Andy Shevchenko wrote: > On Mon, Mar 8, 2021 at 12:57 AM Dmitry Torokhov > wrote: > > On Mon, Mar 08, 2021 at 12:05:48AM +0200, Andy Shevchenko wrote: > > ... > > > > - return !gpio_get_value(ts->gpio); > > > + return !gpiod_get_value(ts->gpiod); > > > > This is not correct. gpio_get_value() is raw polarity vs > > gpiod_get_value() using logical active/inactive, and tsc2007 GPIO lines > > are active low. The negation must be dropped after switching to GPIOD > > API. > > Ah, indeed, I missed that, thanks! > > ... > > > > - ts->gpio = of_get_gpio(np, 0); > > > - if (gpio_is_valid(ts->gpio)) > > > - ts->get_pendown_state = tsc2007_get_pendown_state_gpio; > > > - else > > > - dev_warn(&client->dev, > > > - "GPIO not specified in DT (of_get_gpio returned %d)\n", > > > - ts->gpio); > > > + ts->gpiod = devm_gpiod_get_optional(dev, NULL, GPIOD_IN); > > > > GPIO is definitely not optional in DT case, at least in the way the > > driver written right now. > > Can you elaborate this, please? I don't see from the dev_warn() w/o > any error code returned that it's mandatory. > In the bindings one may read: > > Optional properties: > - gpios: the interrupt gpio the chip is connected to (trough the penirq pin). > The penirq pin goes to low when the panel is touched. > (see GPIO binding[1] for more details). > > Nothing suggested it's mandatory. What have I missed? Ah, indeed, I misread the code and thought we'd abort if there is no pendown GPIO. I wonder if we should remove the warning since we seem to support operations without it. Thanks. -- Dmitry