From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Alistair Francis <alistair@alistair23.me>
Cc: linux-input@vger.kernel.org, linux-imx@nxp.com,
pinglinux@gmail.com, tatsunosuke.tobita@wacom.com,
junkpainting@gmail.com, ping.cheng@wacom.com,
linux-kernel@vger.kernel.org, alistair23@gmail.com,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH v6 2/9] dt-bindings: touchscreen: Initial commit of wacom,generic
Date: Tue, 15 Jun 2021 09:54:41 -0700 [thread overview]
Message-ID: <YMjbUQLT+HMfO77+@google.com> (raw)
In-Reply-To: <20210615103014.798-3-alistair@alistair23.me>
Hi Alistair,
On Tue, Jun 15, 2021 at 08:30:07PM +1000, Alistair Francis wrote:
> Signed-off-by: Alistair Francis <alistair@alistair23.me>
Please also send DT bindings to Rob Herring <robh+dt@kernel.org> and
devicetree@vger.kernel.org.
> ---
> .../input/touchscreen/wacom,generic.yaml | 48 +++++++++++++++++++
> 1 file changed, 48 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/input/touchscreen/wacom,generic.yaml
>
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/wacom,generic.yaml b/Documentation/devicetree/bindings/input/touchscreen/wacom,generic.yaml
> new file mode 100644
> index 000000000000..68f3f5271b77
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/touchscreen/wacom,generic.yaml
> @@ -0,0 +1,48 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/input/touchscreen/wacom,generic.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Wacom I2C Controller
> +
> +maintainers:
> + - Alistair Francis <alistair@alistair23.me>
> +
> +allOf:
> + - $ref: touchscreen.yaml#
> +
> +properties:
> + compatible:
> + const: wacom,generic
This is not an acceptable DT compatible. This needs to be a particular
model of the controller, preferably the first one that supports this
protocol.
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + vdd-supply:
> + description: Power Supply
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include "dt-bindings/interrupt-controller/irq.h"
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + digitiser@9 {
> + compatible = "wacom,generic";
> + reg = <0x9>;
> + interrupt-parent = <&gpio1>;
> + interrupts = <9 IRQ_TYPE_LEVEL_LOW>;
> + vdd-supply = <®_touch>;
> + };
> + };
> --
> 2.31.1
>
Thanks.
--
Dmitry
next prev parent reply other threads:[~2021-06-15 16:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 10:30 [PATCH v6 0/9] Add Wacom I2C support to rM2 Alistair Francis
2021-06-15 10:30 ` [PATCH v6 1/9] dt-bindings: Add Wacom to vendor bindings Alistair Francis
2021-06-15 16:50 ` Dmitry Torokhov
2021-06-15 10:30 ` [PATCH v6 2/9] dt-bindings: touchscreen: Initial commit of wacom,generic Alistair Francis
2021-06-15 16:54 ` Dmitry Torokhov [this message]
2021-06-15 10:30 ` [PATCH v6 3/9] Input: wacom_i2c - Add device tree support to wacom_i2c Alistair Francis
2021-06-15 16:55 ` Dmitry Torokhov
2021-06-15 21:19 ` Alistair Francis
2021-06-15 10:30 ` [PATCH v6 4/9] Input: wacom_i2c - Add touchscren properties Alistair Francis
2021-06-15 10:30 ` [PATCH v6 5/9] Input: wacom_i2c - Add support for distance and tilt x/y Alistair Francis
2021-06-15 10:30 ` [PATCH v6 6/9] Input: wacom_i2c - Clean up the query device fields Alistair Francis
2021-06-15 10:30 ` [PATCH v6 7/9] Input: wacom_i2c - Add support for vdd regulator Alistair Francis
2021-06-15 10:30 ` [PATCH v6 8/9] ARM: imx_v6_v7_defconfig: Enable Wacom I2C Alistair Francis
2021-06-15 10:30 ` [PATCH v6 9/9] ARM: dts: imx7d: remarkable2: add wacom digitizer device Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMjbUQLT+HMfO77+@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=alistair23@gmail.com \
--cc=alistair@alistair23.me \
--cc=junkpainting@gmail.com \
--cc=linux-imx@nxp.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ping.cheng@wacom.com \
--cc=pinglinux@gmail.com \
--cc=robh+dt@kernel.org \
--cc=tatsunosuke.tobita@wacom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).