linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] Input: analog: Always use ktime functions
Date: Tue, 7 Sep 2021 18:43:45 -0700	[thread overview]
Message-ID: <YTgVUWzFSOg/I4C+@google.com> (raw)
In-Reply-To: <20210907123734.21520-1-linux@roeck-us.net>

Hi Guenter,

On Tue, Sep 07, 2021 at 05:37:34AM -0700, Guenter Roeck wrote:
> @@ -241,11 +176,11 @@ static int analog_cooked_read(struct analog_port *port)
>  	int i, j;
>  
>  	loopout = (ANALOG_LOOP_TIME * port->loop) / 1000;
> -	timeout = ANALOG_MAX_TIME * port->speed;
> +	timeout = ANALOG_MAX_TIME * NSEC_PER_MSEC;
>  
>  	local_irq_save(flags);
>  	gameport_trigger(gameport);
> -	now = get_time();
> +	now = ktime_get();

There are time[4], now, etc variables above this block that are u64. I
think they can be make ktime_t. I can do it myself if you agree.

> @@ -378,35 +313,19 @@ static void analog_calibrate_timer(struct analog_port *port)
>  	u64 t1, t2, t3;

I think these should also be ktime_t.

Thanks.

-- 
Dmitry

  parent reply	other threads:[~2021-09-08  1:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-07 12:37 [PATCH v3] Input: analog: Always use ktime functions Guenter Roeck
2021-09-07 12:41 ` Geert Uytterhoeven
2021-09-08  0:52 ` Randy Dunlap
2021-09-08  1:43 ` Dmitry Torokhov [this message]
2021-09-08  2:29   ` Guenter Roeck
2021-09-09  6:40     ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YTgVUWzFSOg/I4C+@google.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=geert@linux-m68k.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).