From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Daniel Mack <daniel@zonque.org>
Cc: linux-input@vger.kernel.org, m.felsch@pengutronix.de
Subject: Re: [PATCH v5 3/3] Input: ads7846: Switch to devm initialization
Date: Thu, 9 Sep 2021 21:29:19 -0700 [thread overview]
Message-ID: <YTrfH3b2RjBEsFQF@google.com> (raw)
In-Reply-To: <20210907200726.2034962-4-daniel@zonque.org>
Hi Daniel,
On Tue, Sep 07, 2021 at 10:07:26PM +0200, Daniel Mack wrote:
> @@ -1392,7 +1392,7 @@ static int ads7846_probe(struct spi_device *spi)
>
> err = sysfs_create_group(&dev->kobj, &ads784x_attr_group);
> if (err)
> - goto err_remove_hwmon;
> + return err;
There is devm_device_add_group() that does what is needed.
Also setting up input device's parent is no longer needed when
devm_input_allocate_device() is used.
I adjusted both, and applied, thank you.
--
Dmitry
prev parent reply other threads:[~2021-09-10 4:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-07 20:07 [PATCH v5 0/3] Input: ads7846: pdata cleanups and devm init Daniel Mack
2021-09-07 20:07 ` [PATCH v5 1/3] Input: ads7846: Add short-hand for spi->dev in probe() function Daniel Mack
2021-09-10 4:26 ` Dmitry Torokhov
2021-09-07 20:07 ` [PATCH v5 2/3] Input: ads7846: Remove custom filter handling functions from pdata Daniel Mack
2021-09-10 4:26 ` Dmitry Torokhov
2021-09-07 20:07 ` [PATCH v5 3/3] Input: ads7846: Switch to devm initialization Daniel Mack
2021-09-10 4:29 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YTrfH3b2RjBEsFQF@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=daniel@zonque.org \
--cc=linux-input@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).