From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E06ADC433FE for ; Fri, 25 Feb 2022 16:23:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240801AbiBYQXu (ORCPT ); Fri, 25 Feb 2022 11:23:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60802 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242930AbiBYQXt (ORCPT ); Fri, 25 Feb 2022 11:23:49 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3F78B3E41; Fri, 25 Feb 2022 08:23:16 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 3DCF6B8326B; Fri, 25 Feb 2022 16:23:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5BF6AC340E7; Fri, 25 Feb 2022 16:23:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1645806193; bh=rkLjTIjcRR32zyhieMNFJ8Z8g6Br2JWE90YX1D0HpYQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PqQA6k5avulgzjLrXS55FBGglRzClfgITBEPzW/sIi1vhdrBB7DzHVsiiDyDC7tIS pSJyavVbhEMdNfhtl/uhpJdcezZIRqUmOeqYedIhPPgDgQddEFuAVas3F4AFMbNZfZ 8MFDo8iejA7WO8GBInhG+K1elmW1Phxw0sSI3vRM= Date: Fri, 25 Feb 2022 17:23:11 +0100 From: Greg KH To: Benjamin Tissoires Cc: Jiri Kosina , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Shuah Khan , Dave Marchevsky , Joe Stringer , Tero Kristo , lkml , "open list:HID CORE LAYER" , netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, Peter Hutterer Subject: Re: [PATCH bpf-next v1 0/6] Introduce eBPF support for HID devices Message-ID: References: <20220224110828.2168231-1-benjamin.tissoires@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org HID selftests question for now: On Fri, Feb 25, 2022 at 05:00:53PM +0100, Benjamin Tissoires wrote: > > > I am not entirely clear on which plan I want to have for userspace. > > > I'd like to have libinput on board, but right now, Peter's stance is > > > "not in my garden" (and he has good reasons for it). > > > So my initial plan is to cook and hold the bpf programs in hid-tools, > > > which is the repo I am using for the regression tests on HID. > > > > Why isn't the hid regression tests in the kernel tree also? That would > > allow all of the testers out there to test things much easier than > > having to suck down another test repo (like Linaro and 0-day and > > kernelci would be forced to do). > > 2 years ago I would have argued that the ease of development of > gitlab.fd.o was more suited to a fast moving project. > > Now... The changes in the core part of the code don't change much so > yes, merging it in the kernel might have a lot of benefits outside of > what you said. The most immediate one is that I could require fixes to > be provided with a test, and merge them together, without having to > hold them until Linus releases a new version. Yes, having a test be required for a fix is a great idea. Many subsystems do this already and it helps a lot. > If nobody complains of having the regression tests in python with > pytest and some Python 3.6+ features, that is definitely something I > should look for. Look at the tools/testing/selftests/ directory today. We already have python3 tests in there, and as long as you follow the proper TAP output format, all should be fine. The tc-testing python code in the kernel trees seems to do that and no one has complained yet :) thanks, greg k-h