From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>
Cc: linux-input@vger.kernel.org,
"Robin van der Gracht" <robin@protonic.nl>,
linux-kernel@vger.kernel.org, kernel@puri.sm,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
stable@vger.kernel.org,
"Martin Kepplinger" <martin.kepplinger@puri.sm>
Subject: Re: [PATCH v2 RESEND] input: keyboard: snvs_pwrkey: Fix SNVS_HPVIDR1 register address
Date: Tue, 27 Sep 2022 07:19:25 -0700 [thread overview]
Message-ID: <YzMGbUQz4YPM5diz@google.com> (raw)
In-Reply-To: <4599101.ElGaqSPkdT@pliszka>
On Tue, Sep 27, 2022 at 08:25:12AM +0200, Sebastian Krzyszkowiak wrote:
> Both i.MX6 and i.MX8 reference manuals list 0xBF8 as SNVS_HPVIDR1
> (chapters 57.9 and 6.4.5 respectively).
>
> Without this, trying to read the revision number results in 0 on
> all revisions, causing the i.MX6 quirk to apply on all platforms,
> which in turn causes the driver to synthesise power button release
> events instead of passing the real one as they happen even on
> platforms like i.MX8 where that's not wanted.
>
> Fixes: 1a26c920717a ("Input: snvs_pwrkey - send key events for i.MX6 S, DL and Q")
> Cc: <stable@vger.kernel.org>
> Tested-by: Martin Kepplinger <martin.kepplinger@puri.sm>
> Signed-off-by: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>
Applied, thank you.
--
Dmitry
prev parent reply other threads:[~2022-09-27 14:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 6:25 [PATCH v2 RESEND] input: keyboard: snvs_pwrkey: Fix SNVS_HPVIDR1 register address Sebastian Krzyszkowiak
2022-09-27 8:12 ` Mattijs Korpershoek
2022-09-27 14:19 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzMGbUQz4YPM5diz@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=kernel@puri.sm \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.kepplinger@puri.sm \
--cc=robin@protonic.nl \
--cc=sebastian.krzyszkowiak@puri.sm \
--cc=stable@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).