From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Andi Shyti <andi.shyti@kernel.org>
Cc: Igor Artemiev <Igor.A.Artemiev@mcst.ru>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
lvc-project@linuxtesting.org
Subject: Re: [lvc-project] [PATCH] Input: trackpoint - remove unreachable code
Date: Fri, 17 Mar 2023 03:18:20 -0700 [thread overview]
Message-ID: <ZBQ+bJQkcZREArAq@google.com> (raw)
In-Reply-To: <20230314131356.cwb4nd7i43sws75j@intel.intel>
On Tue, Mar 14, 2023 at 02:13:56PM +0100, Andi Shyti wrote:
> Hi Igor,
>
> On Tue, Mar 14, 2023 at 03:27:14PM +0300, Igor Artemiev wrote:
> > The trackpoint_sync() function always returnd 0.
> > And there is no need to check its result.
> >
> > Found by Linux Verification Center (linuxtesting.org) with SVACE.
> >
> > Fixes: 2a924d71794c ("Input: trackpoint - only expose supported controls for Elan, ALPS and NXP")
> > Signed-off-by: Igor Artemiev <Igor.A.Artemiev@mcst.ru>
>
> I don't think it requires the Fixes tag... it's not really
> broken.
>
> > ---
> > drivers/input/mouse/trackpoint.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/input/mouse/trackpoint.c b/drivers/input/mouse/trackpoint.c
> > index 4a86b3e31d3b..561a4d2d81ff 100644
> > --- a/drivers/input/mouse/trackpoint.c
> > +++ b/drivers/input/mouse/trackpoint.c
> > @@ -386,9 +386,7 @@ static int trackpoint_reconnect(struct psmouse *psmouse)
> > was_reset = tp->variant_id == TP_VARIANT_IBM &&
> > trackpoint_power_on_reset(&psmouse->ps2dev) == 0;
> >
> > - error = trackpoint_sync(psmouse, was_reset);
> > - if (error)
> > - return error;
> > + trackpoint_sync(psmouse, was_reset);
>
> what worries me here is that if this returns always '0' who tells
> me that it will always return '0'?
>
> One day someone might add an error return path and you would miss
> it here.
>
> Would it make sense to make the trackpoint_sync() a void function
> as well?
Yes if we are dropping the check we should also change the function to
not return anything.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2023-03-17 10:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 12:27 [lvc-project] [PATCH] Input: trackpoint - remove unreachable code Igor Artemiev
2023-03-14 13:13 ` Andi Shyti
2023-03-17 10:18 ` Dmitry Torokhov [this message]
2023-03-17 13:39 ` [lvc-project] [PATCH v2] " Igor Artemiev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBQ+bJQkcZREArAq@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=Igor.A.Artemiev@mcst.ru \
--cc=andi.shyti@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).