linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: msizanoen <msizanoen@qtmlabs.xyz>
Cc: hdegoede@redhat.com, linux-input@vger.kernel.org,
	linux-kernel@vger.kernel.org, pali@kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH v2] input: alps: fix compatibility with -funsigned-char
Date: Sun, 19 Mar 2023 21:43:12 -0700	[thread overview]
Message-ID: <ZBfkYEe0LfITyiUh@google.com> (raw)
In-Reply-To: <20230320001731.175969-1-msizanoen@qtmlabs.xyz>

Hi,

On Mon, Mar 20, 2023 at 01:17:31AM +0100, msizanoen wrote:
> The AlpsPS/2 code previously relied on the assumption that `char` is a
> signed type, which was true on x86 platforms (the only place where this
> driver is used) before kernel 6.2. However, on 6.2 and later, this
> assumption is broken due to the introduction of -funsigned-char as a new
> global compiler flag.
> 
> Fix this by explicitly specifying the signedness of `char` when sign
> extending the values received from the device.
> 
> v2:
> 	Add explicit signedness to more places
> 
> Fixes: f3f33c677699 ("Input: alps - Rushmore and v7 resolution support")
> Cc: stable@vger.kernel.org
> Signed-off-by: msizanoen <msizanoen@qtmlabs.xyz>

Please use s8 instead of signed char. Also, could you please tell me if
"msizanoen" is your real name? It is required in the DCO. Apologies if
it really is.

Thanks.

-- 
Dmitry

  reply	other threads:[~2023-03-20  4:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-18 14:42 [PATCH] input: alps: fix compatibility with -funsigned-char msizanoen
2023-03-18 16:25 ` Hans de Goede
2023-03-19  9:56 ` msizanoen
2023-03-19 16:54   ` Pali Rohár
2023-03-19 17:45 ` Jason A. Donenfeld
2023-03-19 19:43   ` Pali Rohár
2023-03-20  0:17 ` [PATCH v2] " msizanoen
2023-03-20  4:43   ` Dmitry Torokhov [this message]
2023-03-20  4:52 ` [PATCH v3] " msizanoen1
2023-03-20  6:03   ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZBfkYEe0LfITyiUh@google.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=hdegoede@redhat.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=msizanoen@qtmlabs.xyz \
    --cc=pali@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).