From: Giulio Benetti <giulio.benetti@benettiengineering.com>
To: Rob Herring <robh@kernel.org>
Cc: "Linux Input" <linux-input@vger.kernel.org>,
devicetree@vger.kernel.org,
"Jonathan Neuschäfer" <j.ne@posteo.net>,
"Henrik Rydberg" <rydberg@bitmath.org>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/3] dt-bindings: touchscreen: Add HY46XX bindings
Date: Wed, 7 Apr 2021 21:17:48 +0200 [thread overview]
Message-ID: <a19cb8f9-e339-5a82-ff80-205b272b9439@benettiengineering.com> (raw)
In-Reply-To: <CAL_JsqL2QdSmYbcowgsPz2XXQt1W0KfkzqkNROafAsMNXx7m4w@mail.gmail.com>
On 4/7/21 8:56 PM, Rob Herring wrote:
> On Wed, Apr 7, 2021 at 12:57 PM Giulio Benetti
> <giulio.benetti@benettiengineering.com> wrote:
>>
>> Hello Rob, All,
>>
>> On 4/6/21 3:24 PM, Rob Herring wrote:
>>> On Fri, 02 Apr 2021 18:16:26 +0200, Giulio Benetti wrote:
>>>> This adds device tree bindings for the Hycon HY46XX touchscreen series.
>>>>
>>>> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
>>>> ---
>>>> V1->V2:
>>>> As suggested by Rob Herring:
>>>> * fixed $id: address
>>>> * added "hycon," in front of every custom property
>>>> * changed all possible property to boolean type
>>>> * removed proximity-sensor-switch property since it's not handled in driver
>>>> V2->V3:
>>>> As suggested by Jonathan Neuschäfer:
>>>> * fixed some typo
>>>> * fixed description indentation
>>>> * improved boolean properties descriptions
>>>> * improved hycon,report-speed description
>>>> ---
>>>> .../input/touchscreen/hycon,hy46xx.yaml | 120 ++++++++++++++++++
>>>> MAINTAINERS | 6 +
>>>> 2 files changed, 126 insertions(+)
>>>> create mode 100644 Documentation/devicetree/bindings/input/touchscreen/hycon,hy46xx.yaml
>>>>
>>>
>>> My bot found errors running 'make dt_binding_check' on your patch:
>>>
>>> yamllint warnings/errors:
>>>
>>> dtschema/dtc warnings/errors:
>>> Documentation/devicetree/bindings/input/touchscreen/hycon,hy46xx.example.dt.yaml:0:0: /example-0/i2c/hycon-hy4633@1c: failed to match any schema with compatible: ['hycon,hy4633']
>>>
>>> See https://patchwork.ozlabs.org/patch/1461797
>>>
>>> This check can fail if there are any dependencies. The base for a patch
>>> series is generally the most recent rc1.
>>>
>>> If you already ran 'make dt_binding_check' and didn't see the above
>>> error(s), then make sure 'yamllint' is installed and dt-schema is up to
>>> date:
>>
>> I've just send corrected patches.
>>
>> Anyway I'd like to understand how to make dt_binding_check works correctly.
>>
>> I've installed yamllint and 'make dt_binding_check' works but it still
>> doesn't show that error up on compatible string.
>>
>> yamllint I have is version 1.20.0
>>
>>> pip3 install dtschema --upgrade
>>
>> I've already tried with that too and dtschema version is:
>> 1.3.8
>
> Huh? dtschema versions are YYYY.MM.
Sorry, it is 2021.3
>> I've read that dtc must be compiled with YAML output enabled and it
>> seems to be so, since when I issue 'make dt_binding_check' from my file:
>> hycon,hy46xx.yaml(with compatible string wrong "hycon,hy4633")
>
> It's a new check queued for 5.13 in linux-next. See commit
> c59773d204cc ("kbuild: Enable DT undocumented compatible checks").
>
> I've updated the bot email with this, but after I sent this one.
Ah ok, thank you, I'll apply it in my Repos.
Best regards
--
Giulio Benetti
Benetti Engineering sas
next prev parent reply other threads:[~2021-04-07 19:17 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210305163834.70924-1-giulio.benetti@benettiengineering.com>
2021-03-05 16:38 ` [PATCH 2/3] dt-bindings: touchscreen: Add HY46XX bindings Giulio Benetti
2021-03-05 19:34 ` Giulio Benetti
2021-03-06 19:28 ` Rob Herring
2021-03-06 19:41 ` Rob Herring
2021-04-01 18:37 ` Giulio Benetti
2021-04-01 22:24 ` Giulio Benetti
2021-04-01 23:03 ` [PATCH v2 0/3] Input: add Hycon HY46XX Touchscreen controller Giulio Benetti
2021-04-01 23:03 ` [PATCH v2 1/3] dt-bindings: Add Hycon Technology vendor prefix Giulio Benetti
2021-04-01 23:03 ` [PATCH v2 2/3] dt-bindings: touchscreen: Add HY46XX bindings Giulio Benetti
2021-04-02 8:36 ` Jonathan Neuschäfer
2021-04-02 15:17 ` Giulio Benetti
2021-04-01 23:03 ` [PATCH v2 3/3] Input: add driver for the Hycon HY46XX touchpanel series Giulio Benetti
2021-04-02 8:59 ` Jonathan Neuschäfer
2021-04-02 15:23 ` Giulio Benetti
2021-04-02 16:16 ` [PATCH v3 0/3] Input: add Hycon HY46XX Touchscreen controller Giulio Benetti
2021-04-02 16:16 ` [PATCH v3 1/3] dt-bindings: Add Hycon Technology vendor prefix Giulio Benetti
2021-04-02 16:16 ` [PATCH v3 2/3] dt-bindings: touchscreen: Add HY46XX bindings Giulio Benetti
2021-04-06 13:24 ` Rob Herring
2021-04-07 17:57 ` Giulio Benetti
2021-04-07 18:56 ` Rob Herring
2021-04-07 19:17 ` Giulio Benetti [this message]
2021-04-06 13:37 ` Jonathan Neuschäfer
2021-04-06 14:07 ` Giulio Benetti
2021-04-07 17:49 ` [PATCH v4 0/3] Input: add Hycon HY46XX Touchscreen controller Giulio Benetti
2021-04-07 17:49 ` [PATCH v4 1/3] dt-bindings: Add Hycon Technology vendor prefix Giulio Benetti
2021-04-08 20:16 ` Rob Herring
2021-04-07 17:49 ` [PATCH v4 2/3] dt-bindings: touchscreen: Add HY46XX bindings Giulio Benetti
2021-04-08 20:21 ` Rob Herring
2021-04-11 11:37 ` Giulio Benetti
2021-04-11 11:48 ` [PATCH v5 0/3] Input: add Hycon HY46XX Touchscreen controller Giulio Benetti
2021-04-11 11:48 ` [PATCH v5 1/3] dt-bindings: Add Hycon Technology vendor prefix Giulio Benetti
2021-04-12 15:05 ` Rob Herring
2021-04-12 15:12 ` Giulio Benetti
2021-04-13 13:35 ` Rob Herring
2021-04-13 14:44 ` [PATCH v7 0/3] Input: add Hycon HY46XX Touchscreen controller Giulio Benetti
2021-04-13 14:44 ` [PATCH v7 1/3] dt-bindings: Add Hycon Technology vendor prefix Giulio Benetti
2021-04-14 5:44 ` Dmitry Torokhov
2021-04-13 14:44 ` [PATCH v7 2/3] dt-bindings: touchscreen: Add HY46XX bindings Giulio Benetti
2021-04-13 16:36 ` Rob Herring
2021-04-14 5:44 ` Dmitry Torokhov
2021-04-13 14:44 ` [PATCH v7 3/3] Input: add driver for the Hycon HY46XX touchpanel series Giulio Benetti
2021-04-14 5:44 ` Dmitry Torokhov
2021-04-14 6:46 ` Peter Hutterer
2021-04-14 11:22 ` Giulio Benetti
2021-04-14 17:26 ` Dmitry Torokhov
2021-04-15 6:16 ` Peter Hutterer
2021-04-14 11:24 ` Giulio Benetti
2021-04-11 11:48 ` [PATCH v5 2/3] dt-bindings: touchscreen: Add HY46XX bindings Giulio Benetti
2021-04-12 13:20 ` Rob Herring
2021-04-12 14:46 ` Rob Herring
2021-04-12 14:49 ` Giulio Benetti
2021-04-12 15:23 ` [PATCH v6 0/2] Input: add Hycon HY46XX Touchscreen controller Giulio Benetti
2021-04-12 15:23 ` [PATCH v6 1/2] dt-bindings: touchscreen: Add HY46XX bindings Giulio Benetti
2021-04-13 15:07 ` Rob Herring
2021-04-13 15:27 ` Giulio Benetti
2021-04-13 17:58 ` Rob Herring
2021-04-13 18:34 ` Giulio Benetti
2021-04-12 15:24 ` [PATCH v6 2/2] Input: add driver for the Hycon HY46XX touchpanel series Giulio Benetti
2021-04-11 11:48 ` [PATCH v5 3/3] " Giulio Benetti
2021-04-07 17:49 ` [PATCH v4 " Giulio Benetti
2021-04-02 16:16 ` [PATCH v3 " Giulio Benetti
2021-03-05 16:38 ` [PATCH " Giulio Benetti
2021-03-05 19:00 ` Dmitry Torokhov
2021-03-05 19:31 ` Giulio Benetti
2021-03-05 19:54 ` Giulio Benetti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a19cb8f9-e339-5a82-ff80-205b272b9439@benettiengineering.com \
--to=giulio.benetti@benettiengineering.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=j.ne@posteo.net \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=rydberg@bitmath.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).