Linux Input Archive on lore.kernel.org
 help / color / Atom feed
From: Cameron Gutman <aicommander@gmail.com>
To: Ismael Ferreras Morezuelas <swyterzone@gmail.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org,
	Benjamin Valentin <benpicco@zedat.fu-berlin.de>
Subject: Re: [PATCH] Input: xpad: Remove a conflicting Razer Sabertooth using the VID/PID for the Razer DeathAdder 2013 mouse
Date: Thu, 30 Jul 2020 22:54:56 -0700
Message-ID: <a66472a1-b07a-169c-20dc-6d5e51d4d3bc@gmail.com> (raw)
In-Reply-To: <b9e7cb27-1866-83bb-b453-ae265ab6bde6@gmail.com>

On 7/30/20 8:44 AM, Ismael Ferreras Morezuelas wrote:
> While doing my research to improve the xpad device names I also noticed
> that the 1532:0037 VID/PID seems to be used by the DeathAdder 2013,
> so that Razer Sabertooth instance looked wrong and very suspect to
> me. I didn't see any mention in the official drivers, either.
> 
> After doing more research, it turns out that the xpad list
> is used by many other projects (like Steam) as-is, this
> issue was reported and Valve/Sam Lantinga fixed it:
> 
> https://steamcommunity.com/app/353380/discussions/0/1743392486228754770/
> 
> (With multiple Internet users reporting similar issues, not linked here)
> 
> After not being able to find the correct VID/PID combination anywhere
> on the Internet and not receiving any reply from Razer support I did
> some additional detective work, it seems like it presents itself as
> "Razer Sabertooth Gaming Controller (XBOX360)", code 1689:FE00.
> 
> Leaving us with this:
>  * Razer Sabertooth (1689:fe00)
>  * Razer Sabertooth Elite (24c6:5d04)
>  * Razer DeathAdder 2013 (1532:0037) [note: not a gamepad]
> 
> So, to sum things up; remove this conflicting/duplicate entry:
> 
> { 0x1532, 0x0037, "Razer Sabertooth", 0, XTYPE_XBOX360 },
> 
> As the real/correct one is already present there, even if
> the Internet as a whole insists on presenting it as the
> Razer Sabertooth Elite, which (by all accounts) is not:
> 
> { 0x1689, 0xfe00, "Razer Sabertooth", 0, XTYPE_XBOX360 },
> 
> That's it. No other functional changes intended.
> 
> Fixes: f554f619b70 ("Input: xpad - sync device IDs with xboxdrv")
> Signed-off-by: Ismael Ferreras Morezuelas <swyterzone@gmail.com>
> ---
>  drivers/input/joystick/xpad.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
> index c77cdb3b62b5..1510438c5578 100644
> --- a/drivers/input/joystick/xpad.c
> +++ b/drivers/input/joystick/xpad.c
> @@ -249,7 +249,6 @@ static const struct xpad_device {
>  	{ 0x1430, 0x8888, "TX6500+ Dance Pad (first generation)", MAP_DPAD_TO_BUTTONS, XTYPE_XBOX },
>  	{ 0x1430, 0xf801, "RedOctane Controller", 0, XTYPE_XBOX360 },
>  	{ 0x146b, 0x0601, "BigBen Interactive XBOX 360 Controller", 0, XTYPE_XBOX360 },
> -	{ 0x1532, 0x0037, "Razer Sabertooth", 0, XTYPE_XBOX360 },
>  	{ 0x1532, 0x0a00, "Razer Atrox Arcade Stick", MAP_TRIGGERS_TO_BUTTONS, XTYPE_XBOXONE },
>  	{ 0x1532, 0x0a03, "Razer Wildcat", 0, XTYPE_XBOXONE },
>  	{ 0x15e4, 0x3f00, "Power A Mini Pro Elite", 0, XTYPE_XBOX360 },
> 

The list here doesn't actually affect which devices that xpad will attach to.
xpad_table[] is what determines the devices that xpad's probe() will be
called for. It does this using the VID + vendor-defined interface subclass
and interface number, not the VID+PID combos. xpad_device[] just provides a
friendly name and quirk flags for some supported gamepads. Gamepads that
aren't in the list will just show up as "Generic X-Box pad" with no quirk
flags applied.

If 1532:0037 is actually a mouse, it's unlikely we'd even reach the probe()
in the first place. The device would lack the expected vendor-defined Xbox
interface that is required for xpad to attach to the device.

All that said, I'm definitely not opposed to removing the entry if it isn't
a real gamepad. Given the difficulty you had finding information about this
device, I take it you don't have any 'lsusb -v' output for this device, right?

Regards,
Cameron

  reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-30 15:44 Ismael Ferreras Morezuelas
2020-07-31  5:54 ` Cameron Gutman [this message]
2020-07-31  6:14   ` Swyter
2020-08-02 22:50     ` Cameron Gutman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a66472a1-b07a-169c-20dc-6d5e51d4d3bc@gmail.com \
    --to=aicommander@gmail.com \
    --cc=benpicco@zedat.fu-berlin.de \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=swyterzone@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux Input Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-input/0 linux-input/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-input linux-input/ https://lore.kernel.org/linux-input \
		linux-input@vger.kernel.org
	public-inbox-index linux-input

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-input


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git