Re: [PATCH] HID: add cmedia-fixup driver

["Thomas Weißschuh" <linux@weissschuh.net>]

On Do, 2021-07-15T21:14+0200, Jiri Kosina wrote:
> On Thu, 15 Jul 2021, Thomas Weißschuh wrote:
> 
> > > > This driver provides HID fixups for CMedia audio chips.
> > > > For now this enables the recognition of the microphone mute button for the
> > > > HS-100B.
> > > > 
> > > > Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> > > > ---
> > > >  drivers/hid/Kconfig            |  6 +++
> > > >  drivers/hid/Makefile           |  1 +
> > > >  drivers/hid/hid-cmedia-fixup.c | 82 ++++++++++++++++++++++++++++++++++
> > > >  drivers/hid/hid-ids.h          |  1 +
> > > >  drivers/hid/hid-quirks.c       |  3 ++
> > > >  5 files changed, 93 insertions(+)
> > > >  create mode 100644 drivers/hid/hid-cmedia-fixup.c
> > > 
> > > Can you please drop the '-fixup' from the driver name? We have quite a 
> > > couple of drivers that do report descriptor modifications, but we're not 
> > > using this '-fixup' naming scheme for them either.
> > 
> > There is already an existing driver "hid-cmedia":
> > "HID driver for CMedia CM6533 audio jack controls".
> > 
> > This driver works in a completely different way from mine, so I thought 
> > to keep them separate. The idea was for the new driver to be a 
> > collection of simple, similar report fixups.
> > 
> > Should they be combined?
> 
> If it's the same vendor, then yes. We generally (with exceptions, of 
> course :) ) group the HID drivers by vendor, even if completely different 
> quirks are needed for different devices from the same vendor.

Will do.

Should I merge it into the existing `struct hid_driver` and do id checks in
every member function or declare a dedicated `struct hid_driver`?

Thanks!