Re: linux kernel HID problem with Saitek X52 Pro Flight System

From: Jiri Kosina <jkosina@suse.cz>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Stefan Bader <stefan.bader@canonical.com>,
	Anssi Hannula <anssi.hannula@iki.fi>,
	Tim Cole <tim.cole@canonical.com>,
	Sergey Kolesnikov <rockingdemon@gmail.com>,
	linux-input@vger.kernel.org
Subject: Re: linux kernel HID problem with Saitek X52 Pro Flight System
Date: Tue, 22 Dec 2009 14:31:49 +0100 (CET)	[thread overview]
Message-ID: <alpine.LNX.2.00.0912221430500.3755@pobox.suse.cz> (raw)
In-Reply-To: <20091218174905.GA23450@core.coreip.homeip.net>

On Fri, 18 Dec 2009, Dmitry Torokhov wrote:

> > > > > #define BTN_TRIGGER_HAPPY01	0x210
> > > > > ...
> > > > > #define BTN_TRIGGER_HAPPY40	0x238
> > > > > 
> > > > > :-P Assuming 40 additional buttons should be crazy enough (but I know
> > > > > this has been said before about other things).
> > > > 
> > > > Dmitry, do you have any preference here yourself?
> > > 
> > > "Trigger happy" sounds fine.
> > 
> > OK, so how about something along the lines below?
> 
> How about we move trigger happy further towards the 0x2ff limit?

Sure, no problem. Just tell me the range you'd be comfortable with, and 
I'll apply a patch using that range.

> Also, do we clamp the bit numbers at KEY_MAX? 

Good point. I'll update all the map_*() macros in a separate patch and add 
range overflow checks.

> Otherwise looks good, please push through your tree.

Thanks,

-- 
Jiri Kosina
SUSE Labs, Novell Inc.