From: Jiri Kosina <jkosina@suse.cz>
To: Stephane Chatty <chatty@lii-enac.fr>
Cc: linux-input@vger.kernel.org, chatty@enac.fr
Subject: Re: [PATCH] Fixed bug in single-touch emulation on the Stantum panel
Date: Tue, 9 Feb 2010 16:34:47 +0100 (CET) [thread overview]
Message-ID: <alpine.LNX.2.00.1002091633250.30967@pobox.suse.cz> (raw)
In-Reply-To: <20100206141912.71BA89520A@smtp.lii-enac.fr>
On Sat, 6 Feb 2010, Stephane Chatty wrote:
>
> Fixed bug in touchscreen emulation for the Stantum multitouch panel
>
> Signed-off-by: Stephane Chatty <chatty@enac.fr>
>
> diff -rupN a/drivers/hid/hid-stantum.c b/drivers/hid/hid-stantum.c
> --- a/drivers/hid/hid-stantum.c 2010-02-06 14:59:57.000000000 +0100
> +++ b/drivers/hid/hid-stantum.c 2010-02-06 15:00:36.000000000 +0100
> @@ -16,7 +16,7 @@
> #include <linux/hid.h>
> #include <linux/module.h>
>
> -MODULE_VERSION("1.00");
> +MODULE_VERSION("1.01");
> MODULE_AUTHOR("Stephane Chatty <chatty@enac.fr>");
> MODULE_DESCRIPTION("Stantum HID multitouch panels");
> MODULE_LICENSE("GPL");
> @@ -147,7 +147,6 @@ static void stantum_filter_event(struct
>
> input_mt_sync(input);
> sd->valid = false;
> - sd->first = false;
>
> /* touchscreen emulation */
> if (sd->first) {
> @@ -158,6 +157,7 @@ static void stantum_filter_event(struct
> input_event(input, EV_ABS, ABS_X, sd->x);
> input_event(input, EV_ABS, ABS_Y, sd->y);
> }
> + sd->first = false;
> }
It doesn't apply to the driver I have in the tree. That claims to be
version 0.6, and it doesn't contain this bug.
Perhaps you forgot to submit a patch refreshing the driver to newer
version (or perhaps I have missed it?).
Thanks,
--
Jiri Kosina
SUSE Labs, Novell Inc.
next prev parent reply other threads:[~2010-02-09 15:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-06 14:19 [PATCH] Fixed bug in single-touch emulation on the Stantum panel Stephane Chatty
2010-02-09 10:27 ` Jiri Kosina
2010-02-09 14:59 ` Stéphane Chatty
2010-02-09 19:49 ` Dmitry Torokhov
2010-02-09 15:34 ` Jiri Kosina [this message]
2010-02-09 17:05 ` Stéphane Chatty
2010-02-10 11:04 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1002091633250.30967@pobox.suse.cz \
--to=jkosina@suse.cz \
--cc=chatty@enac.fr \
--cc=chatty@lii-enac.fr \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).