linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Kosina <jkosina-AlSwsSmVLrQ@public.gmane.org>
To: Michael Poole <mdpoole-IZmAEv5cUt1AfugRpC6u6w@public.gmane.org>
Cc: linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Marcel Holtmann <marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>,
	linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/2] Add a device driver for the Apple Magic Mouse.
Date: Wed, 10 Feb 2010 14:06:16 +0100 (CET)	[thread overview]
Message-ID: <alpine.LNX.2.00.1002101404210.30967@pobox.suse.cz> (raw)
In-Reply-To: <87pr4eeemz.fsf_-_-IZmAEv5cUt1AfugRpC6u6w@public.gmane.org>

On Tue, 9 Feb 2010, Michael Poole wrote:

> >From da3e2b0330fccd584ad79495853e638e9652155b Mon Sep 17 00:00:00 2001
> From: Michael Poole <mdpoole-IZmAEv5cUt1AfugRpC6u6w@public.gmane.org>
> Date: Sat, 6 Feb 2010 12:24:36 -0500
> Subject: Add a device driver for the Apple Magic Mouse.
> 
> Signed-off-by: Michael Poole <mdpoole-IZmAEv5cUt1AfugRpC6u6w@public.gmane.org>
> ---
>  drivers/hid/Kconfig          |   10 +
>  drivers/hid/Makefile         |    1 +
>  drivers/hid/hid-core.c       |    1 +
>  drivers/hid/hid-ids.h        |    1 +
>  drivers/hid/hid-magicmouse.c |  469 ++++++++++++++++++++++++++++++++++++++++++
>  5 files changed, 482 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/hid/hid-magicmouse.c
> 
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index 24d90ea..ba14ec8 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -183,6 +183,16 @@ config LOGIRUMBLEPAD2_FF
>  	  Say Y here if you want to enable force feedback support for Logitech
>  	  Rumblepad 2 devices.
>  
> +config HID_MAGICMOUSE
> +	tristate "Apple" if EMBEDDED

Could you please make this something else than "Apple"? This string is 
already used by HID_APPLE.

Thanks,

-- 
Jiri Kosina
SUSE Labs, Novell Inc.

  parent reply	other threads:[~2010-02-10 13:06 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <alpine.LNX.2.00.1001291515560.356@pobox.suse.cz>
     [not found] ` <dd18b0c31002082322m4238a4a6m73fc30752ba30447@mail.gmail.com>
     [not found]   ` <1265710460.2383.5685.camel@localhost.localdomain>
     [not found]     ` <201002090736.55576.edt@aei.ca>
     [not found]       ` <alpine.LNX.2.00.1002091339190.30967@pobox.suse.cz>
     [not found]         ` <alpine.LNX.2.00.1002091339190.30967-ztGlSCb7Y1iN3ZZ/Hiejyg@public.gmane.org>
2010-02-09 13:10           ` [PATCH 0/2] Provide a driver for the Apple Magic Mouse Michael Poole
     [not found]             ` <87y6j2eeqv.fsf_-_-IZmAEv5cUt1AfugRpC6u6w@public.gmane.org>
2010-02-09 13:11               ` [PATCH 1/2] " Michael Poole
2010-02-09 21:37               ` [PATCH 0/2] " Justin P. Mattock
2010-02-10 13:57               ` Jiri Kosina
2010-02-13 19:29                 ` [PATCH 0/2] Provide a driver for the Apple Magic Mouse - opps Ed Tomlinson
2010-02-14  8:03                   ` Dmitry Torokhov
     [not found]                     ` <20100214080344.GA4423-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org>
2010-02-14 14:22                       ` Ed Tomlinson
2010-02-15  7:11                         ` Dmitry Torokhov
     [not found]                           ` <20100215071145.GA9135-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org>
2010-02-15 12:42                             ` Ed Tomlinson
2010-02-15 12:44                           ` Ed Tomlinson
2010-02-16 12:57                             ` Jiri Kosina
2010-02-16 12:34                           ` Ed Tomlinson
2010-02-16 12:55                             ` Jiri Kosina
     [not found]                 ` <alpine.LNX.2.00.1002101456490.30967-ztGlSCb7Y1iN3ZZ/Hiejyg@public.gmane.org>
2010-02-14 22:24                   ` [PATCH 1/1] Enable xy scrolling for Apple Magic Mouse Ed Tomlinson
2010-02-14 22:51                     ` Michael Poole
     [not found]                       ` <87zl3bbfdo.fsf-IZmAEv5cUt1AfugRpC6u6w@public.gmane.org>
2010-02-14 23:58                         ` Ed Tomlinson
2010-02-15  7:18                           ` Dmitry Torokhov
     [not found]                             ` <20100215071850.GB9135-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org>
2010-02-15 12:50                               ` Ed Tomlinson
2010-02-15  0:18                       ` Ed Tomlinson
2010-02-09 13:13             ` [PATCH 2/2] Add a device driver for the " Michael Poole
2010-02-10 18:20               ` Dmitry Torokhov
     [not found]                 ` <20100210182024.GA29610-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org>
2010-02-10 20:31                   ` Michael Poole
2010-02-11  5:32                 ` [PATCH] hid-magicmouse: Coding style and probe failure fixes Michael Poole
     [not found]                   ` <873a18e3qu.fsf_-_-IZmAEv5cUt1AfugRpC6u6w@public.gmane.org>
2010-02-11  6:55                     ` Dmitry Torokhov
2010-02-11 10:26                   ` Jiri Kosina
2010-02-11 23:10                     ` Michael Poole
     [not found]               ` <87pr4eeemz.fsf_-_-IZmAEv5cUt1AfugRpC6u6w@public.gmane.org>
2010-02-10 13:06                 ` Jiri Kosina [this message]
     [not found]                   ` <alpine.LNX.2.00.1002101404210.30967-ztGlSCb7Y1iN3ZZ/Hiejyg@public.gmane.org>
2010-02-10 13:58                     ` [PATCH 2/2] Add a device driver for the Apple Magic Mouse Jiri Kosina
2010-02-11  3:05                 ` Ed Tomlinson
     [not found]                   ` <201002102205.58967.edt-Yad3+ZauZac@public.gmane.org>
2010-02-11  3:20                     ` Michael Poole
2010-02-11 12:51                       ` [PATCH 2/2] Add a device driver for the Apple Magic Mouse (2.6.32.8) Ed Tomlinson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LNX.2.00.1002101404210.30967@pobox.suse.cz \
    --to=jkosina-alswssmvlrq@public.gmane.org \
    --cc=linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org \
    --cc=mdpoole-IZmAEv5cUt1AfugRpC6u6w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).