From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Kosina Subject: Re: [PATCH] Input: add appleir USB driver Date: Mon, 19 Apr 2010 12:00:25 +0200 (CEST) Message-ID: References: <1271434792.2045.5.camel@localhost.localdomain> <20100417081212.GA19866@core.coreip.homeip.net> <1271669507.17421.39.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: Received: from cantor.suse.de ([195.135.220.2]:55435 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751813Ab0DSKA0 (ORCPT ); Mon, 19 Apr 2010 06:00:26 -0400 In-Reply-To: <1271669507.17421.39.camel@localhost.localdomain> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Bastien Nocera Cc: Dmitry Torokhov , linux-input@vger.kernel.org On Mon, 19 Apr 2010, Bastien Nocera wrote: > > > A few comments... > > > > > > > Signed-off-by: Bastien Nocera > > > > --- > > > > Documentation/input/appleir.txt | 45 ++++ > > > > drivers/hid/hid-apple.c | 4 - > > > > drivers/hid/hid-core.c | 5 +- > > > > drivers/hid/hid-ids.h | 1 + > > > > > > HID pieces need to go through Jiri or he needs to ack them to go through > > > my tree... > > > > Please feel free to put > > > > Signed-off-by: Jiri Kosina > > > > on the blakclist changes in drivers/hid once you merge the > > standalone appleir driver from Bastien. > > Any comments on the additional quirks necessary to get lirc working? Ouch, I thought that we have discussed previously that I am basically fine with adding those two quirks, but I haven't seen any patch doing that since then ... ? So I'd suggest you either remove that part from the appleir documentation until this is implemented, or send me a patch adding those two flags. Thanks, -- Jiri Kosina SUSE Labs, Novell Inc.