From: Jiri Kosina <jkosina@suse.cz>
To: Simon Wood <simon@mungewell.org>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID:hid-logitech: Prevent possibility of infinite loop when using /sys interface
Date: Tue, 12 Aug 2014 16:30:20 +0200 (CEST) [thread overview]
Message-ID: <alpine.LNX.2.00.1408121630000.15220@pobox.suse.cz> (raw)
In-Reply-To: <1407379951-7038-1-git-send-email-simon@mungewell.org>
On Wed, 6 Aug 2014, Simon Wood wrote:
> If the device data is not accessible for some reason, returning 0 will cause the call to be
> continuously called again as none of the string has been 'consumed'.
Hi Simon,
this patch is missing signoff.
> ---
> drivers/hid/hid-lg4ff.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hid/hid-lg4ff.c b/drivers/hid/hid-lg4ff.c
> index cc2bd20..7835717 100644
> --- a/drivers/hid/hid-lg4ff.c
> +++ b/drivers/hid/hid-lg4ff.c
> @@ -451,13 +451,13 @@ static ssize_t lg4ff_range_store(struct device *dev, struct device_attribute *at
> drv_data = hid_get_drvdata(hid);
> if (!drv_data) {
> hid_err(hid, "Private driver data not found!\n");
> - return 0;
> + return -EINVAL;
> }
>
> entry = drv_data->device_props;
> if (!entry) {
> hid_err(hid, "Device properties not found!\n");
> - return 0;
> + return -EINVAL;
> }
>
> if (range == 0)
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2014-08-12 14:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-07 2:52 [PATCH] HID:hid-logitech: Prevent possibility of infinite loop when using /sys interface Simon Wood
2014-08-12 14:30 ` Jiri Kosina [this message]
2014-08-15 2:43 ` [PATCHv2] " Simon Wood
2014-08-15 8:56 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1408121630000.15220@pobox.suse.cz \
--to=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=simon@mungewell.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).