From: Guenter Roeck <linux@roeck-us.net>
To: Peng Fan <peng.fan@nxp.com>, Anson Huang <anson.huang@nxp.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Shawn Guo <shawnguo@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
"dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>,
"a.zummo@towertech.it" <a.zummo@towertech.it>,
"rui.zhang@intel.com" <rui.zhang@intel.com>,
"daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>,
"amit.kucheria@verdurent.com" <amit.kucheria@verdurent.com>,
"wim@linux-watchdog.org" <wim@linux-watchdog.org>,
Daniel Baluta <daniel.baluta@nxp.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux@rempel-privat.de" <linux@rempel-privat.de>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"m.felsch@pengutronix.de" <m.felsch@pengutronix.de>,
"andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
"arnd@arndb.de" <arnd@arndb.de>,
"ronald@innovation.ch" <ronald@innovation.ch>,
"krzk@kernel.org" <krzk@kernel.org>,
"robh@kernel.org" <robh@kernel.org>,
Leonard Crestez <leonard.crestez@nxp.com>,
Aisheng Dong <aisheng.dong@nxp.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH V3 1/7] firmware: imx: Add stubs for !CONFIG_IMX_SCU case
Date: Mon, 16 Mar 2020 19:32:46 -0700 [thread overview]
Message-ID: <b049be1c-1f3f-54fc-3c47-0873d95cb769@roeck-us.net> (raw)
In-Reply-To: <AM0PR04MB4481A54C639FD1D45098302088F60@AM0PR04MB4481.eurprd04.prod.outlook.com>
On 3/16/20 7:18 PM, Peng Fan wrote:
>> Subject: RE: [PATCH V3 1/7] firmware: imx: Add stubs for !CONFIG_IMX_SCU
>> case
>>
>> Hi, Alexandre
>>
>>> -----Original Message-----
>>> From: Alexandre Belloni <alexandre.belloni@bootlin.com>
>>> Sent: Monday, March 16, 2020 5:16 PM
>>> To: Anson Huang <anson.huang@nxp.com>
>>> Cc: Shawn Guo <shawnguo@kernel.org>; Peng Fan <peng.fan@nxp.com>;
>>> s.hauer@pengutronix.de; kernel@pengutronix.de; festevam@gmail.com;
>>> dmitry.torokhov@gmail.com; a.zummo@towertech.it;
>> rui.zhang@intel.com;
>>> daniel.lezcano@linaro.org; amit.kucheria@verdurent.com; wim@linux-
>>> watchdog.org; linux@roeck-us.net; Daniel Baluta
>>> <daniel.baluta@nxp.com>; gregkh@linuxfoundation.org;
>>> linux@rempel-privat.de; tglx@linutronix.de; m.felsch@pengutronix.de;
>>> andriy.shevchenko@linux.intel.com;
>>> arnd@arndb.de; ronald@innovation.ch; krzk@kernel.org; robh@kernel.org;
>>> Leonard Crestez <leonard.crestez@nxp.com>; Aisheng Dong
>>> <aisheng.dong@nxp.com>; linux-arm-kernel@lists.infradead.org; linux-
>>> kernel@vger.kernel.org; linux-input@vger.kernel.org; linux-
>>> rtc@vger.kernel.org; linux-pm@vger.kernel.org; linux-
>>> watchdog@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com>
>>> Subject: Re: [PATCH V3 1/7] firmware: imx: Add stubs for
>>> !CONFIG_IMX_SCU case
>>>
>>> On 16/03/2020 09:08:53+0000, Anson Huang wrote:
>>>>> Why do you absolutely need to compile them independently? From a
>>>>> code coverage point of view, having:
>>>>>
>>>>> COMPILE_TEST=y
>>>>> CONFIG_IMX_SCU=y
>>>>>
>>>>> is enough to select and compile the remaining drivers.
>>>>
>>>> What I meant is for below case, like using other arch config which
>>>> does NOT have CONFIG_IMX_SCU selected, ONLY with COMPILE_TEST
>>>> selected, adding stubs for IMX_SCU APIs can fix such scenario.
>>>>
>>>> COMPILE_TEST=y
>>>> CONFIG_IMX_SCU=n
>>>>
>>>
>>> Why is that an issue? If they don't have IMX_SCU selected, then the
>>> other SCU driver are not selected either, having stubs doesn't change
>>> that you will have to select at least one option. Please explain what
>>> is the issue that is not solved here.
>>
>> OK, what I thought is even without IMX_SCU selected, other SCU drivers still
>> can be selected for build test after adding "COMPILE_TEST" to the kconfig,
>> like below, if without IMX_SCU API stubs, the "COMPILE_TEST" can NOT be
>> added to SCU drivers to enable build test, so I think the IMX_SCU API stubs
>> should be added?
>
> Forgot to mention, without stub api, for drivers with
> " #include <linux/firmware/imx/sci.h> " will met compile error without
> +#ifdef CONFIG_IMX_SCU
> +#endif
>
> So we have to use ifdef CONFIG_IMX_SCU to guard the include.
>
Add "depends on IMX_SCU" to the Kconfig entry for those drivers,
and/or drop "COMPILE_TEST" from their Kconfig entry.
Really, COMPILE_TEST is abused here. I start to understand those who
advocate that it should be removed. This is an excellent case in point.
Guenter
next prev parent reply other threads:[~2020-03-17 2:32 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-09 0:38 [PATCH V3 1/7] firmware: imx: Add stubs for !CONFIG_IMX_SCU case Anson Huang
2020-03-09 0:38 ` [PATCH V3 2/7] firmware: imx: add COMPILE_TEST support Anson Huang
2020-03-16 0:53 ` Shawn Guo
2020-03-16 3:37 ` Shawn Guo
2020-03-09 0:38 ` [PATCH V3 3/7] rtc: add COMPILE_TEST support for i.MX SC RTC Anson Huang
2020-03-09 0:38 ` [PATCH V3 4/7] input: keyboard: add COMPILE_TEST support for KEYBOARD_IMX_SC_KEY Anson Huang
2020-03-09 0:38 ` [PATCH V3 5/7] input: keyboard: imx_sc_key: Fix build warning for !CONFIG_IMX_SCU case Anson Huang
2020-03-09 0:38 ` [PATCH V3 6/7] watchdog: add COMPILE_TEST support for IMX_SC_WDT Anson Huang
2020-03-09 0:38 ` [PATCH V3 7/7] thermal: add COMPILE_TEST support for IMX_SC_THERMAL Anson Huang
2020-03-09 11:06 ` [PATCH V3 1/7] firmware: imx: Add stubs for !CONFIG_IMX_SCU case Alexandre Belloni
2020-03-09 12:20 ` Anson Huang
2020-03-09 13:27 ` Guenter Roeck
2020-03-09 13:37 ` Anson Huang
2020-03-09 16:47 ` Alexandre Belloni
2020-03-09 17:10 ` Guenter Roeck
2020-03-09 17:30 ` Alexandre Belloni
2020-03-09 18:19 ` Guenter Roeck
2020-03-09 13:40 ` Peng Fan
2020-03-09 14:09 ` Anson Huang
2020-03-16 0:52 ` Shawn Guo
2020-03-16 2:51 ` Peng Fan
2020-03-16 3:07 ` Shawn Guo
2020-03-16 3:18 ` Peng Fan
2020-03-16 3:34 ` Shawn Guo
2020-03-16 8:04 ` Anson Huang
2020-03-16 8:40 ` Alexandre Belloni
2020-03-16 8:44 ` Anson Huang
2020-03-16 9:00 ` Alexandre Belloni
2020-03-16 9:08 ` Anson Huang
2020-03-16 9:15 ` Alexandre Belloni
2020-03-16 9:40 ` Anson Huang
2020-03-16 10:00 ` Alexandre Belloni
2020-03-16 10:18 ` Anson Huang
2020-03-17 2:18 ` Peng Fan
2020-03-17 2:29 ` Anson Huang
2020-03-17 2:32 ` Guenter Roeck [this message]
2020-03-17 2:35 ` Anson Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b049be1c-1f3f-54fc-3c47-0873d95cb769@roeck-us.net \
--to=linux@roeck-us.net \
--cc=a.zummo@towertech.it \
--cc=aisheng.dong@nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=amit.kucheria@verdurent.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=anson.huang@nxp.com \
--cc=arnd@arndb.de \
--cc=daniel.baluta@nxp.com \
--cc=daniel.lezcano@linaro.org \
--cc=dmitry.torokhov@gmail.com \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=krzk@kernel.org \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=m.felsch@pengutronix.de \
--cc=peng.fan@nxp.com \
--cc=robh@kernel.org \
--cc=ronald@innovation.ch \
--cc=rui.zhang@intel.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=tglx@linutronix.de \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).