From: Yannick FERTRE <yannick.fertre@st.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>
Cc: Philippe CORNU <philippe.cornu@st.com>,
Benjamin GAIGNARD <benjamin.gaignard@st.com>,
Bastien Nocera <hadess@hadess.net>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] Input: goodix - support gt9147 touchpanel
Date: Thu, 5 Dec 2019 08:30:26 +0000 [thread overview]
Message-ID: <bd51e553feb74f6fb3a7115463d52e66@SFHDAG6NODE1.st.com> (raw)
In-Reply-To: <20191201030818.GM248138@dtor-ws>
Hello,
Dmitry,
I forgot to modify the binding to declare the new compatible "gt9147".
Rob,
can I modify the binding without converting it first to yaml?
Best regards
Yannick Fertré
-----Original Message-----
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Sent: dimanche 1 décembre 2019 04:08
To: Yannick FERTRE <yannick.fertre@st.com>; Rob Herring <robh+dt@kernel.org>
Cc: Philippe CORNU <philippe.cornu@st.com>; Benjamin GAIGNARD <benjamin.gaignard@st.com>; Bastien Nocera <hadess@hadess.net>; linux-input@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: goodix - support gt9147 touchpanel
On Wed, Nov 27, 2019 at 11:28:46AM +0100, Yannick Fertre wrote:
> From: Yannick Fertré <yannick.fertre@st.com>
>
> Add support for it by adding compatible and supported chip data
> (default settings used).
> The chip data on GT9147 is similar to GT912, like
> - config data register has 0x8047 address
> - config data register max len is 240
> - config data checksum has 8-bit
If it is compatible with gt912 then the driver does not need another compatible in the code I think. Rob will tell more.
>
> Signed-off-by: Yannick Fertre <yannick.fertre@st.com>
> ---
> drivers/input/touchscreen/goodix.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/touchscreen/goodix.c
> b/drivers/input/touchscreen/goodix.c
> index fb43aa7..b470773 100644
> --- a/drivers/input/touchscreen/goodix.c
> +++ b/drivers/input/touchscreen/goodix.c
> @@ -1045,6 +1045,7 @@ static const struct of_device_id goodix_of_match[] = {
> { .compatible = "goodix,gt9271" },
> { .compatible = "goodix,gt928" },
> { .compatible = "goodix,gt967" },
> + { .compatible = "goodix,gt9147",},
> { }
> };
> MODULE_DEVICE_TABLE(of, goodix_of_match);
> --
> 2.7.4
>
--
Dmitry
prev parent reply other threads:[~2019-12-05 8:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 10:28 [PATCH] Input: goodix - support gt9147 touchpanel Yannick Fertre
2019-12-01 3:08 ` Dmitry Torokhov
2019-12-05 8:30 ` Yannick FERTRE [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd51e553feb74f6fb3a7115463d52e66@SFHDAG6NODE1.st.com \
--to=yannick.fertre@st.com \
--cc=benjamin.gaignard@st.com \
--cc=dmitry.torokhov@gmail.com \
--cc=hadess@hadess.net \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=philippe.cornu@st.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).