From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85A5DC010A2 for ; Tue, 5 Nov 2019 11:46:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5890621A4A for ; Tue, 5 Nov 2019 11:46:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730784AbfKELqX (ORCPT ); Tue, 5 Nov 2019 06:46:23 -0500 Received: from metis.ext.pengutronix.de ([85.220.165.71]:50685 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730876AbfKELqW (ORCPT ); Tue, 5 Nov 2019 06:46:22 -0500 Received: from kresse.hi.pengutronix.de ([2001:67c:670:100:1d::2a]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1iRxHx-0003vY-HE; Tue, 05 Nov 2019 12:46:21 +0100 Message-ID: Subject: Re: [PATCH resend 2/3] Input: synaptics-rmi4 - add dummy F54 attention handler From: Lucas Stach To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, patchwork-lst@pengutronix.de, kernel@pengutronix.de Date: Tue, 05 Nov 2019 12:46:21 +0100 In-Reply-To: <20191105000359.GS57214@dtor-ws> References: <20191104114454.10500-1-l.stach@pengutronix.de> <20191104114454.10500-2-l.stach@pengutronix.de> <20191105000359.GS57214@dtor-ws> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::2a X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-input@vger.kernel.org Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Hi Dmitry, On Mo, 2019-11-04 at 16:03 -0800, Dmitry Torokhov wrote: > On Mon, Nov 04, 2019 at 12:44:53PM +0100, Lucas Stach wrote: > > F54 is IRQ capable, even if it is not used in the current driver > > implementation. The common driver code in rmi_create_function_irq always > > installs a irq handler for functions that are IRQ capable. Without a > > assigned attention handler, this means a NULL pointer being passed as > > the nested IRQ handler. This seems to work with some architecture > > implementations, but crashes on others like ARM64. > > > > Don't rely on implementation defined behavior and actually install > > a proper attention handler. > > Instead of supplying dummy IRQ handler, can't we simply disable relevant > interrupts bits? Don't know why I didn't try this last time. I vaguely remember that not enabling the IRQs didn't help. I just retested and it seems the IRQs are enabled by default, so we need to actively disable them. I just sent out a patch which does exactly this. Regards, Lucas