From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E9A1C43331 for ; Wed, 1 Apr 2020 09:49:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 583E420787 for ; Wed, 1 Apr 2020 09:49:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732144AbgDAJtA (ORCPT ); Wed, 1 Apr 2020 05:49:00 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:54533 "EHLO relay9-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731396AbgDAJtA (ORCPT ); Wed, 1 Apr 2020 05:49:00 -0400 X-Originating-IP: 83.155.44.161 Received: from classic (mon69-7-83-155-44-161.fbx.proxad.net [83.155.44.161]) (Authenticated sender: hadess@hadess.net) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id F12D6FF811; Wed, 1 Apr 2020 09:48:57 +0000 (UTC) Message-ID: Subject: Re: [PATCH v2] Input: goodix - Fix compilation when ACPI support is disabled From: Bastien Nocera To: Hans de Goede , Dmitry Torokhov Cc: linux-input@vger.kernel.org, kbuild test robot Date: Wed, 01 Apr 2020 11:48:56 +0200 In-Reply-To: <939fa592-599c-35cf-908e-d0b29639c992@redhat.com> References: <20200325150246.128463-1-hdegoede@redhat.com> <20200401014529.GL75430@dtor-ws> <939fa592-599c-35cf-908e-d0b29639c992@redhat.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.0 (3.36.0-1.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Wed, 2020-04-01 at 11:14 +0200, Hans de Goede wrote: > Hi, > > On 4/1/20 3:45 AM, Dmitry Torokhov wrote: > > Hi Hans, > > > > On Wed, Mar 25, 2020 at 04:02:46PM +0100, Hans de Goede wrote: > > > acpi_evaluate_object() and acpi_execute_simple_method() are not > > > part of > > > the group of ACPI related functions which get stubbed by > > > include/linux/acpi.h when ACPI support is disabled, so the > > > IRQ_PIN_ACCESS_ACPI_METHOD handling code must be disabled through > > > an #ifdef when ACPI support is not enabled. > > > > > > For consistency also #ifdef out the IRQ_PIN_ACCESS_ACPI_GPIO code > > > and use the same #if condition as which is used to replace > > > goodix_add_acpi_gpio_mappings with a stub. > > > > I am not big fun of multiple #ifdefs sprinkled through the code, > > can we > > do more straightforward stubs, like below? > > The solution you suggested is fine with me. The patch itself is slightly confusing (it looks like it's renaming functions), but looks pretty much like I requested, so: Reviewed-by: Bastien Nocera