From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,UNWANTED_LANGUAGE_BODY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1B05C433DF for ; Wed, 20 May 2020 16:54:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 764572065F for ; Wed, 20 May 2020 16:54:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726823AbgETQy4 (ORCPT ); Wed, 20 May 2020 12:54:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50720 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726510AbgETQyz (ORCPT ); Wed, 20 May 2020 12:54:55 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A8CFFC061A0E; Wed, 20 May 2020 09:54:55 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: eballetbo) with ESMTPSA id 1E3692A2D17 Subject: Re: [PATCHv3 5/5] Input: EXC3000: Add reset gpio support To: Sebastian Reichel , Dmitry Torokhov , Ahmet Inan , Martin Fuzzey Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@collabora.com References: <20200520153936.46869-1-sebastian.reichel@collabora.com> <20200520153936.46869-6-sebastian.reichel@collabora.com> From: Enric Balletbo i Serra Message-ID: Date: Wed, 20 May 2020 18:54:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200520153936.46869-6-sebastian.reichel@collabora.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Hi Sebastian, On 20/5/20 17:39, Sebastian Reichel wrote: > Add basic support for an optional reset gpio. > > Signed-off-by: Sebastian Reichel Thanks to address the comments I did in second version. so, Reviewed-by: Enric Balletbo i Serra > --- > .../input/touchscreen/eeti,exc3000.yaml | 2 ++ > drivers/input/touchscreen/exc3000.c | 17 +++++++++++++++++ > 2 files changed, 19 insertions(+) > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/eeti,exc3000.yaml b/Documentation/devicetree/bindings/input/touchscreen/eeti,exc3000.yaml > index 7e6e23f8fa00..007adbc89c14 100644 > --- a/Documentation/devicetree/bindings/input/touchscreen/eeti,exc3000.yaml > +++ b/Documentation/devicetree/bindings/input/touchscreen/eeti,exc3000.yaml > @@ -22,6 +22,8 @@ properties: > const: 0x2a > interrupts: > maxItems: 1 > + reset-gpios: > + maxItems: 1 > touchscreen-size-x: true > touchscreen-size-y: true > touchscreen-inverted-x: true > diff --git a/drivers/input/touchscreen/exc3000.c b/drivers/input/touchscreen/exc3000.c > index b5a3bbb63504..de9d0ae1210a 100644 > --- a/drivers/input/touchscreen/exc3000.c > +++ b/drivers/input/touchscreen/exc3000.c > @@ -8,7 +8,9 @@ > */ > > #include > +#include > #include > +#include > #include > #include > #include > @@ -33,6 +35,9 @@ > > #define EXC3000_TIMEOUT_MS 100 > > +#define EXC3000_RESET_MS 10 > +#define EXC3000_READY_MS 100 > + > static const struct i2c_device_id exc3000_id[]; > > struct eeti_dev_info { > @@ -66,6 +71,7 @@ struct exc3000_data { > const struct eeti_dev_info *info; > struct input_dev *input; > struct touchscreen_properties prop; > + struct gpio_desc *reset; > struct timer_list timer; > u8 buf[2 * EXC3000_LEN_FRAME]; > struct completion wait_event; > @@ -325,6 +331,17 @@ static int exc3000_probe(struct i2c_client *client) > init_completion(&data->wait_event); > mutex_init(&data->query_lock); > > + data->reset = devm_gpiod_get_optional(&client->dev, "reset", > + GPIOD_OUT_HIGH); > + if (IS_ERR(data->reset)) > + return PTR_ERR(data->reset); > + > + if (data->reset) { > + msleep(EXC3000_RESET_MS); > + gpiod_set_value_cansleep(data->reset, 0); > + msleep(EXC3000_READY_MS); > + } > + > input = devm_input_allocate_device(&client->dev); > if (!input) > return -ENOMEM; >