Re: [PATCH] Logitech G13 driver (fixed cc list --- ignore others)

["Rick L. Vinyard, Jr." <rvinyard@cs.nmsu.edu>]

Hello,

Felipe Balbi wrote:
> On Mon, Dec 14, 2009 at 10:22:32PM +0100, ext Rick L. Vinyard Jr. wrote:
>>
>>Signed-off-by: Rick L. Vinyard, Jr <rvinyard@cs.nmsu.edu>
>
> there are plenty of style mistakes in this patch. the body message
> description which you put below should be above the signed-off-by line,

Fixed in the new patch labelled 0.0.2

> multi-lined comments are of the form:
>
> /*
>   * multi lined comment
>   * goes here
>   */
>

Fixed

> remove the commented code like /* hid_debug = 0 */
>

Removed

> and some others.. please run your patch through scripts/checkpatch.pl
> --strict and fix the errors and warnings reported.
>

I ran it without the --strict option before. That's probably why I didn't
catch it. It's clean now with --strict.

>>+static int __init g13_init(void)
>>+{
>>+       pr_debug("g13 HID driver loaded");
>
> don't pr_debug() here.
>

Removed

>>+       return hid_register_driver(&g13_driver);
>>+}
>>+
>>+static void __exit g13_exit(void)
>>+{
>>+       pr_debug("g13 HID driver unloaded");
>
> nor here.
>
>>+       hid_unregister_driver(&g13_driver);
>>+}

Removed

Thanks for the input. Everything above is taken into account in v0.0.2 of
the patch.

---

Rick