From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B62ACA9EC7 for ; Sat, 2 Nov 2019 19:35:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E818F21783 for ; Sat, 2 Nov 2019 19:35:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572723315; bh=MuKISYn7aL/t1Jz68PuFO9zEm0915XMIQ0YVXRpWqD8=; h=Date:From:To:cc:Subject:In-Reply-To:References:List-ID:From; b=TjcbuaWbBuMUE3VLdaek8Bi+N3HXX0db/C36+/KoppMltYyyl+dKhFJjn3RlrLqb/ CkCqbJdOWt1xTlL0EPdrN2l30Z7sNZ2lv67wErN29tEGWi9BHCGhmu9NeqhDUlkfeg HmvN6yiGPbV4oLLi62VL7d4OzuBVkAnSIZSHmtpY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727200AbfKBTfO (ORCPT ); Sat, 2 Nov 2019 15:35:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:39778 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726634AbfKBTfO (ORCPT ); Sat, 2 Nov 2019 15:35:14 -0400 Received: from pobox.suse.cz (prg-ext-pat.suse.com [213.151.95.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 723F820862; Sat, 2 Nov 2019 19:35:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572723313; bh=MuKISYn7aL/t1Jz68PuFO9zEm0915XMIQ0YVXRpWqD8=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=urMQDf1XeWV1klVhoAijv93T6sKCPRw2p5ysKO/3rPaje3q6sN+oxMC9Ii9atk34t cB4InKYJj8yhma1cQIlgDdzFdAG513hVCUpebVr9zsnwTWKaH9HXZ9/s/EOcIMPnI1 nJS4WinquCK3j4eEzJlPYKcpr0mrQCvS6dnS/kA0= Date: Sat, 2 Nov 2019 20:35:03 +0100 (CET) From: Jiri Kosina To: Hans de Goede cc: Benjamin Tissoires , linux-input@vger.kernel.org, Kai-Heng Feng Subject: Re: [PATCH] HID: i2c-hid: Send power-on command after reset In-Reply-To: <20191020214718.150906-1-hdegoede@redhat.com> Message-ID: References: <20191020214718.150906-1-hdegoede@redhat.com> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Sun, 20 Oct 2019, Hans de Goede wrote: > Before commit 67b18dfb8cfc ("HID: i2c-hid: Remove runtime power > management"), any i2c-hid touchscreens would typically be runtime-suspended > between the driver loading and Xorg or a Wayland compositor opening it, > causing it to be resumed again. This means that before this change, > we would call i2c_hid_set_power(OFF), i2c_hid_set_power(ON) before the > graphical session would start listening to the touchscreen. > > It turns out that at least some SIS touchscreens, such as the one found > on the Asus T100HA, need a power-on command after reset, otherwise they > will not send any events. > > Fixes: 67b18dfb8cfc ("HID: i2c-hid: Remove runtime power management") > Cc: Kai-Heng Feng > Signed-off-by: Hans de Goede Thanks a lot for debugging this. I've queued this in for-5.4/upstream-fixes and will make sure it hits Linus' tree before 5.4 final. -- Jiri Kosina SUSE Labs