From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEF11C432C3 for ; Fri, 15 Nov 2019 12:20:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A1AB72075E for ; Fri, 15 Nov 2019 12:20:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573820433; bh=TyM1iIX/py+lg8xnlUsnl1Ktj1Bv0w98SjBjsVImFJY=; h=Date:From:To:cc:Subject:In-Reply-To:References:List-ID:From; b=TIH5Z0p2TFiRkZZtMfe9smCk7sRTLD3B58E4ByT/LEY38zk1aBOTDlRFL7TGku70l 5u8/vMNqpKFnsyUeCKY3pUzV8YpfuQJGmg2yyBv1j9/nm9eFtyJH2xV1GwJVOfCTb1 SNioG0/1g8DX2wM3Ly0bld2F11TLLVjOXHnlGYww= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727306AbfKOMUd (ORCPT ); Fri, 15 Nov 2019 07:20:33 -0500 Received: from mail.kernel.org ([198.145.29.99]:53120 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727196AbfKOMUd (ORCPT ); Fri, 15 Nov 2019 07:20:33 -0500 Received: from pobox.suse.cz (prg-ext-pat.suse.com [213.151.95.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EACE620740; Fri, 15 Nov 2019 12:20:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573820432; bh=TyM1iIX/py+lg8xnlUsnl1Ktj1Bv0w98SjBjsVImFJY=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=f5s+aRT5RFtUhbdD9AxDBU6s33IpaDN3I+jqZ5HXiLVT/LHyjD+ZXFQ4UuY4EJnFa NFl7QXylIySsPNKBvnOcRjAvmK86e1KDQsPYdfu4/1QYQqchGC7rSdqXxuBvoiSzit 2kiqT3qfPFhzq8E95RLedjNJItLyhWzcb5mv/+6g= Date: Fri, 15 Nov 2019 13:20:28 +0100 (CET) From: Jiri Kosina To: You-Sheng Yang cc: Benjamin Tissoires , Kai-Heng Feng , Hui Wang , HungNien Chen , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] HID: i2c-hid: remove orphaned member sleep_delay In-Reply-To: <20191115053646.3107290-1-vicamo.yang@canonical.com> Message-ID: References: <20191115053646.3107290-1-vicamo.yang@canonical.com> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Fri, 15 Nov 2019, You-Sheng Yang wrote: > This was introduced in commit 00b790ea545b ("HID: i2c-hid: Add a small > delay after sleep command for Raydium touchpanel") which has been > effectively reverted by commit 67b18dfb8cfc ("HID: i2c-hid: Remove > runtime power management"). > > Signed-off-by: You-Sheng Yang > --- > drivers/hid/i2c-hid/i2c-hid-core.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/hid/i2c-hid/i2c-hid-core.c b/drivers/hid/i2c-hid/i2c-hid-core.c > index 04c088131e04..adfe344bc786 100644 > --- a/drivers/hid/i2c-hid/i2c-hid-core.c > +++ b/drivers/hid/i2c-hid/i2c-hid-core.c > @@ -157,8 +157,6 @@ struct i2c_hid { > > bool irq_wake_enabled; > struct mutex reset_lock; > - > - unsigned long sleep_delay; > }; Applied, thanks. -- Jiri Kosina SUSE Labs