From: Jiri Kosina <jikos@kernel.org>
To: Andrew Duggan <aduggan@synaptics.com>
Cc: "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Federico Cerutti <federico@ceres-c.it>,
Christopher Heiny <Cheiny@synaptics.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: Re: [PATCH] HID: rmi: Check that the RMI_STARTED bit is set before unregistering the RMI transport device
Date: Mon, 18 Nov 2019 10:24:19 +0100 (CET) [thread overview]
Message-ID: <nycvar.YFH.7.76.1911181024040.1799@cbobk.fhfr.pm> (raw)
In-Reply-To: <6931c116-78fb-9ad9-aab1-f15799118c82@synaptics.com>
On Fri, 15 Nov 2019, Andrew Duggan wrote:
> Since this second patch was for the input subsystem I decided to just
> make them separate patches instead of creating a series. However, based
> on Dmitry's feedback it was determined that the second patch wasn't a
> good idea and it won't be applied. This first patch is enough to fix the
> issue by preventing the call to rmi_unregister_transport_device() if the
> subsequent call to register failed. The only change I would make to this
> patch would be to remove the last sentence of the comment. If you choose
> to apply that patch then would this be a change you would make? Or would
> you prefer I submit a v2 with this update?
I've modified the changelog and applied. Thanks,
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2019-11-18 9:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 1:24 [PATCH] HID: rmi: Check that the RMI_STARTED bit is set before unregistering the RMI transport device Andrew Duggan
2019-10-23 1:24 ` [PATCH] Input: synaptics-rmi4 - validate that the rmi_dev pointer is set before dereferencing it Andrew Duggan
2019-10-29 4:19 ` Dmitry Torokhov
2019-10-29 18:40 ` Andrew Duggan
2019-11-15 15:26 ` [PATCH] HID: rmi: Check that the RMI_STARTED bit is set before unregistering the RMI transport device Jiri Kosina
2019-11-15 18:18 ` Andrew Duggan
2019-11-18 9:24 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.1911181024040.1799@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=Cheiny@synaptics.com \
--cc=aduggan@synaptics.com \
--cc=benjamin.tissoires@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=federico@ceres-c.it \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).