From: Jiri Kosina <jikos@kernel.org>
To: Mansour Behabadi <mansour@oxplot.com>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: apple: Add support for recent firmware
Date: Tue, 4 Feb 2020 13:48:35 +0100 (CET) [thread overview]
Message-ID: <nycvar.YFH.7.76.2002041347250.26888@cbobk.fhfr.pm> (raw)
In-Reply-To: <20200129062631.22694-1-mansour@oxplot.com>
On Wed, 29 Jan 2020, Mansour Behabadi wrote:
> Magic Keyboards with more recent firmware (0x0100) report
> Fn key differently. Without this patch, Fn key may not
> behave as expected and may not be configurable via hid_apple
> fnmode module parameter.
>
> Signed-off-by: Mansour Behabadi <mansour@oxplot.com>
> ---
> drivers/hid/hid-apple.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c
> index 6ac8becc2372..d732d1d10caf 100644
> --- a/drivers/hid/hid-apple.c
> +++ b/drivers/hid/hid-apple.c
> @@ -340,7 +340,8 @@ static int apple_input_mapping(struct hid_device *hdev, struct hid_input *hi,
> unsigned long **bit, int *max)
> {
> if (usage->hid == (HID_UP_CUSTOM | 0x0003) ||
> - usage->hid == (HID_UP_MSVENDOR | 0x0003)) {
> + usage->hid == (HID_UP_MSVENDOR | 0x0003) ||
> + usage->hid == (HID_UP_HPVENDOR2 | 0x0003)) {
> /* The fn key on Apple USB keyboards */
Hmm, one day we should probably ditch this "vendor-specific" naming, which
doesn't really match reality at all any more.
Also the mappings in hid-input for these usage pages are pretty awkward
these days.
Anyway, that is for later. I am queuing your patch now, thanks.
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2020-02-04 12:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-29 6:26 [PATCH] HID: apple: Add support for recent firmware Mansour Behabadi
2020-02-04 12:48 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2002041347250.26888@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mansour@oxplot.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).