From: Jiri Kosina <jikos@kernel.org>
To: "Shah, Nehal-bakulchandra" <nehal-bakulchandra.shah@amd.com>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Hans de Goede <hdegoede@redhat.com>,
Sandeep Singh <Sandeep.Singh@amd.com>,
lkml <linux-kernel@vger.kernel.org>,
"open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
Jonathan Cameron <jic23@kernel.org>,
linux-iio@vger.kernel.org, Shyam-sundar.S-k@amd.com
Subject: Re: [PATCH v3 0/5] SFH: Add Support for AMD Sensor Fusion Hub
Date: Fri, 21 Feb 2020 13:47:38 +0100 (CET) [thread overview]
Message-ID: <nycvar.YFH.7.76.2002211346070.13129@cbobk.fhfr.pm> (raw)
In-Reply-To: <79506ad3-5172-be36-cecc-19d97bfa8b36@amd.com>
On Wed, 19 Feb 2020, Shah, Nehal-bakulchandra wrote:
> > 2 problems here:
> > - patch 3/5 references this debugfs interface which is only added in 4/5.
> > - you are creating a new sysfs set of file for debug purpose only, but
> > as soon as we start shipping those, some other people will find it
> > more convenient to use that directly instead or IIO, and you won't be
> > able to change anything there.
> >
> > So I would strongly advocate against having this debugfs, and suggest you to:
> > - either keep this debugfs as a downstream patch
> > - either play with eBPF or kprobes to retrieve the same information
> > without changing the kernel.
> >
> > For reference, I recently tried to replicate the hidraw functionality
> > with eBPF[0] without changing the kernel code, and it was working.
> > Well, there was no filtering on the source of the HID event, but
> > still, I got the same data directly from the kernel just by adding
> > instrumentation in a couple of functions.
Wow. Complete eBPF supremacy is really coming shortly apparently :)
> If Jiri is Ok, then we will push the next patch as per suggestion here
> i.e. taking out debugfs.
I agree with that. Thanks,
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2020-02-21 12:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-12 2:56 [PATCH v3 0/5] SFH: Add Support for AMD Sensor Fusion Hub Sandeep Singh
2020-02-12 2:56 ` [PATCH v3 1/5] SFH: Add maintainers and documentation for AMD SFH based on HID framework Sandeep Singh
2020-02-12 2:56 ` [PATCH v3 2/5] SFH: PCI driver to add support of AMD sensor fusion Hub using " Sandeep Singh
2020-02-12 2:56 ` [PATCH v3 3/5] SFH: Transport Driver to add support of AMD Sensor Fusion Hub (SFH) Sandeep Singh
2020-02-12 2:56 ` [PATCH v3 4/5] SFH: Add debugfs support to AMD Sensor Fusion Hub Sandeep Singh
2020-02-12 2:56 ` [PATCH v3 5/5] SFH: Create HID report to Enable support of AMD sensor fusion Hub (SFH) Sandeep Singh
2020-02-12 14:45 ` [PATCH v3 0/5] SFH: Add Support for AMD Sensor Fusion Hub Hans de Goede
2020-02-13 14:56 ` Benjamin Tissoires
2020-02-14 4:40 ` Srinivas Pandruvada
2020-02-14 10:04 ` Shah, Nehal-bakulchandra
2020-02-14 11:11 ` Benjamin Tissoires
2020-02-19 15:04 ` Shah, Nehal-bakulchandra
2020-02-21 12:47 ` Jiri Kosina [this message]
2020-02-14 11:11 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2002211346070.13129@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=Sandeep.Singh@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=benjamin.tissoires@redhat.com \
--cc=hdegoede@redhat.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nehal-bakulchandra.shah@amd.com \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).