linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Kosina <jikos@kernel.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Federico Ricchiuto <fed.ricchiuto@gmail.com>,
	jikos@kernal.org,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Kai-Heng Feng <kai.heng.feng@canonical.com>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: i2c-hid: add Trekstor Surfbook E11B to descriptor override
Date: Tue, 16 Jun 2020 17:19:08 +0200 (CEST)	[thread overview]
Message-ID: <nycvar.YFH.7.76.2006161718550.13242@cbobk.fhfr.pm> (raw)
In-Reply-To: <197d680d-a38b-b478-1b7a-9c821ada0846@redhat.com>

On Tue, 16 Jun 2020, Hans de Goede wrote:

> Hi,
> 
> On 6/15/20 10:49 PM, Federico Ricchiuto wrote:
> > The Mediacom FlexBook edge13 uses the SIPODEV SP1064 touchpad, which does
> > not supply descriptors, so it has to be added to the override list.
> > 
> > Signed-off-by: Federico Ricchiuto <fed.ricchiuto@gmail.com>
> 
> It looks like you copied and pasted part of the commit message from
> another patch (which is fine), but you need to update the Subject
> (the first line of the commit message) the Subject now still
> mentions the Trekstor Surfbook E11B rather then the
> Mediacom FlexBook edge13.
> 
> Otherwise this looks good to me.

Thanks. I've fixed up the subject and applied.

-- 
Jiri Kosina
SUSE Labs


  reply	other threads:[~2020-06-16 15:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-15 20:49 [PATCH] HID: i2c-hid: add Trekstor Surfbook E11B to descriptor override Federico Ricchiuto
2020-06-16 11:30 ` Hans de Goede
2020-06-16 15:19   ` Jiri Kosina [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-02-14  6:53 Kai-Heng Feng
2020-02-14  8:32 ` Hans de Goede
2020-02-14 10:40   ` Benjamin Tissoires

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=nycvar.YFH.7.76.2006161718550.13242@cbobk.fhfr.pm \
    --to=jikos@kernel.org \
    --cc=benjamin.tissoires@redhat.com \
    --cc=fed.ricchiuto@gmail.com \
    --cc=hdegoede@redhat.com \
    --cc=jikos@kernal.org \
    --cc=kai.heng.feng@canonical.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).