From: Jiri Kosina <jikos@kernel.org>
To: Marc Zyngier <maz@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, kernel-team@android.com
Subject: Re: [PATCH] HID: core: Correctly handle ReportSize being zero
Date: Tue, 1 Sep 2020 10:14:15 +0200 (CEST) [thread overview]
Message-ID: <nycvar.YFH.7.76.2009011013400.4671@cbobk.fhfr.pm> (raw)
In-Reply-To: <20200829112601.1060527-1-maz@kernel.org>
On Sat, 29 Aug 2020, Marc Zyngier wrote:
> It appears that a ReportSize value of zero is legal, even if a bit
> non-sensical. Most of the HID code seems to handle that gracefully,
> except when computing the total size in bytes. When fed as input to
> memset, this leads to some funky outcomes.
>
> Detect the corner case and correctly compute the size.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Marc Zyngier <maz@kernel.org>
Thanks Marc; Benjamin will be pushing this patch through his regression
testing machinery, and if all is good, I'll push it for 5.9-rc still.
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2020-09-01 8:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-29 11:26 [PATCH] HID: core: Correctly handle ReportSize being zero Marc Zyngier
2020-09-01 8:14 ` Jiri Kosina [this message]
2020-09-01 9:34 ` Benjamin Tissoires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2009011013400.4671@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=kernel-team@android.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).