* [PATCH] HID: multitouch: Lenovo X1 Tablet Gen3 trackpoint and buttons
@ 2020-09-19 20:04 Mikael Wikström
2020-09-22 9:16 ` Jiri Kosina
0 siblings, 1 reply; 4+ messages in thread
From: Mikael Wikström @ 2020-09-19 20:04 UTC (permalink / raw)
To: Jiri Kosina, Benjamin Tissoires; +Cc: linux-input, linux-kernel
One more device that needs 40d5bb87 to resolve regression for the trackpoint
and three mouse buttons on the type cover of the Lenovo X1 Tablet Gen3.
It is probably also needed for the Lenovo X1 Tablet Gen2 with PID 0x60a3
Signed-off-by: Mikael Wikström <leakim.wikstrom@gmail.com>
---
drivers/hid/hid-ids.h | 1 +
drivers/hid/hid-multitouch.c | 6 ++++++
2 files changed, 7 insertions(+)
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index 74fc1df6e3c2..6a6e2c1b6090 100644
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -727,6 +727,7 @@
#define USB_DEVICE_ID_LENOVO_TP10UBKBD 0x6062
#define USB_DEVICE_ID_LENOVO_TPPRODOCK 0x6067
#define USB_DEVICE_ID_LENOVO_X1_COVER 0x6085
+#define USB_DEVICE_ID_LENOVO_X1_TAB3 0x60b5
#define USB_DEVICE_ID_LENOVO_PIXART_USB_MOUSE_608D 0x608d
#define USB_DEVICE_ID_LENOVO_PIXART_USB_MOUSE_6019 0x6019
#define USB_DEVICE_ID_LENOVO_PIXART_USB_MOUSE_602E 0x602e
diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
index e3152155c4b8..99f041afd5c0 100644
--- a/drivers/hid/hid-multitouch.c
+++ b/drivers/hid/hid-multitouch.c
@@ -1973,6 +1973,12 @@ static const struct hid_device_id mt_devices[] = {
HID_DEVICE(BUS_I2C, HID_GROUP_GENERIC,
USB_VENDOR_ID_LG, I2C_DEVICE_ID_LG_7010) },
+ /* Lenovo X1 TAB Gen 3 */
+ { .driver_data = MT_CLS_WIN_8_FORCE_MULTI_INPUT,
+ HID_DEVICE(BUS_USB, HID_GROUP_MULTITOUCH_WIN_8,
+ USB_VENDOR_ID_LENOVO,
+ USB_DEVICE_ID_LENOVO_X1_TAB3) },
+
/* MosArt panels */
{ .driver_data = MT_CLS_CONFIDENCE_MINUS_ONE,
MT_USB_DEVICE(USB_VENDOR_ID_ASUS,
--
2.26.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] HID: multitouch: Lenovo X1 Tablet Gen3 trackpoint and buttons
2020-09-19 20:04 [PATCH] HID: multitouch: Lenovo X1 Tablet Gen3 trackpoint and buttons Mikael Wikström
@ 2020-09-22 9:16 ` Jiri Kosina
0 siblings, 0 replies; 4+ messages in thread
From: Jiri Kosina @ 2020-09-22 9:16 UTC (permalink / raw)
To: Mikael Wikström; +Cc: Benjamin Tissoires, linux-input, linux-kernel
On Sat, 19 Sep 2020, Mikael Wikström wrote:
> One more device that needs 40d5bb87 to resolve regression for the trackpoint
> and three mouse buttons on the type cover of the Lenovo X1 Tablet Gen3.
>
> It is probably also needed for the Lenovo X1 Tablet Gen2 with PID 0x60a3
>
> Signed-off-by: Mikael Wikström <leakim.wikstrom@gmail.com>
Thanks for the patch. Unfortunately it has been whitespace damaged by your
client. Could you please fix that up (some help might be found in [1]) and
resubmit?
Thanks.
[1] Documentation/process/email-clients.rst
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] HID: multitouch: Lenovo X1 Tablet Gen3 trackpoint and buttons
2019-02-09 18:05 leakim.wikstrom
@ 2019-02-13 23:06 ` Jiri Kosina
0 siblings, 0 replies; 4+ messages in thread
From: Jiri Kosina @ 2019-02-13 23:06 UTC (permalink / raw)
To: Mikael Wikström; +Cc: Benjamin Tissoires, linux-input, linux-kernel
On Sat, 9 Feb 2019, leakim.wikstrom@gmail.com wrote:
> From: Mikael Wikström <leakim.wikstrom@gmail.com>
>
> Add support for the trackpoint and three mouse buttons on the type cover
> of the Lenovo X1 Tablet Gen3.
>
> This is the same as with the 2nd generation Lenovo X1 Tablet.
>
> Signed-off-by: Mikael Wikström <leakim.wikstrom@gmail.com>
Applied, thanks Mikael.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] HID: multitouch: Lenovo X1 Tablet Gen3 trackpoint and buttons
@ 2019-02-09 18:05 leakim.wikstrom
2019-02-13 23:06 ` Jiri Kosina
0 siblings, 1 reply; 4+ messages in thread
From: leakim.wikstrom @ 2019-02-09 18:05 UTC (permalink / raw)
To: Jiri Kosina
Cc: Mikael Wikström, Benjamin Tissoires, linux-input, linux-kernel
From: Mikael Wikström <leakim.wikstrom@gmail.com>
Add support for the trackpoint and three mouse buttons on the type cover
of the Lenovo X1 Tablet Gen3.
This is the same as with the 2nd generation Lenovo X1 Tablet.
Signed-off-by: Mikael Wikström <leakim.wikstrom@gmail.com>
---
drivers/hid/hid-ids.h | 1 +
drivers/hid/hid-multitouch.c | 6 ++++++
2 files changed, 7 insertions(+)
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index f63489c882bb..500c8f64f7ae 100644
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -703,6 +703,7 @@
#define USB_DEVICE_ID_LENOVO_TPPRODOCK 0x6067
#define USB_DEVICE_ID_LENOVO_X1_COVER 0x6085
#define USB_DEVICE_ID_LENOVO_X1_TAB 0x60a3
+#define USB_DEVICE_ID_LENOVO_X1_TAB3 0x60b5
#define USB_VENDOR_ID_LG 0x1fd2
#define USB_DEVICE_ID_LG_MULTITOUCH 0x0064
diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
index f7c6de2b6730..03a69049ca52 100644
--- a/drivers/hid/hid-multitouch.c
+++ b/drivers/hid/hid-multitouch.c
@@ -1780,6 +1780,12 @@ static const struct hid_device_id mt_devices[] = {
USB_VENDOR_ID_LENOVO,
USB_DEVICE_ID_LENOVO_X1_TAB) },
+ /* Lenovo X1 TAB Gen 3 */
+ { .driver_data = MT_CLS_WIN_8_DUAL,
+ HID_DEVICE(BUS_USB, HID_GROUP_MULTITOUCH_WIN_8,
+ USB_VENDOR_ID_LENOVO,
+ USB_DEVICE_ID_LENOVO_X1_TAB3) },
+
/* Anton devices */
{ .driver_data = MT_CLS_EXPORT_ALL_INPUTS,
MT_USB_DEVICE(USB_VENDOR_ID_ANTON,
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-22 9:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-19 20:04 [PATCH] HID: multitouch: Lenovo X1 Tablet Gen3 trackpoint and buttons Mikael Wikström
2020-09-22 9:16 ` Jiri Kosina
-- strict thread matches above, loose matches on Subject: below --
2019-02-09 18:05 leakim.wikstrom
2019-02-13 23:06 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).