From: Jiri Kosina <jikos@kernel.org>
To: Wolfram Sang <wsa@kernel.org>
Cc: Sultan Alsawaf <sultan@kerneltoast.com>,
linux-i2c@vger.kernel.org, aaron.ma@canonical.com,
admin@kryma.net, andriy.shevchenko@linux.intel.com,
benjamin.tissoires@redhat.com, hdegoede@redhat.com,
hn.chen@weidahitech.com, jarkko.nikula@linux.intel.com,
kai.heng.feng@canonical.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, mika.westerberg@linux.intel.com,
vicamo.yang@canonical.com
Subject: Re: [PATCH v2 0/4] i2c-hid: Save power by reducing i2c xfers with block reads
Date: Tue, 22 Sep 2020 21:59:44 +0200 (CEST) [thread overview]
Message-ID: <nycvar.YFH.7.76.2009222159170.3336@cbobk.fhfr.pm> (raw)
In-Reply-To: <20200922113646.GA6731@ninjato>
On Tue, 22 Sep 2020, Wolfram Sang wrote:
> > Hans, Benjamin, could you please give this patchset some smoke-testing? It
> > looks good to me, but I'd like it to get some testing from your testing
> > machinery before merging.
>
> Please give me some more days. I am not fully convinced yet that this
> use of I2C_M_RECV_LEN is not broken on some controllers.
>
> Plus, I'd favor if this could go via I2C tree. It is within I2C where
> the non-trivial changes are. The HID part is just the final bit. Can we
> agree on that?
Absolutely no problem with that. But I'd like to have this ran through
Benjamin/Hans first too.
Thanks,
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2020-09-22 19:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 5:22 [PATCH v2 0/4] i2c-hid: Save power by reducing i2c xfers with block reads Sultan Alsawaf
2020-09-17 5:22 ` [PATCH v2 1/4] i2c: designware: Fix transfer failures for invalid SMBus " Sultan Alsawaf
2020-09-17 5:22 ` [PATCH v2 2/4] i2c: designware: Ensure tx_buf_len is nonzero for " Sultan Alsawaf
2020-09-17 12:47 ` Andy Shevchenko
2020-09-17 13:44 ` Jarkko Nikula
2020-09-17 14:45 ` Andy Shevchenko
2020-09-17 5:22 ` [PATCH v2 3/4] i2c: designware: Allow SMBus block reads up to 255 bytes in length Sultan Alsawaf
2020-09-17 20:57 ` Wolfram Sang
2020-09-17 23:12 ` Sultan Alsawaf
2020-09-17 5:22 ` [PATCH v2 4/4] HID: i2c-hid: Use block reads when possible to save power Sultan Alsawaf
2020-09-17 14:02 ` [PATCH v2 0/4] i2c-hid: Save power by reducing i2c xfers with block reads Andy Shevchenko
2020-09-23 13:59 ` Jarkko Nikula
2020-09-22 9:19 ` Jiri Kosina
2020-09-22 11:36 ` Wolfram Sang
2020-09-22 19:59 ` Jiri Kosina [this message]
2020-09-23 6:02 ` Sultan Alsawaf
2020-10-16 11:16 ` Hans de Goede
2020-10-16 15:24 ` Sultan Alsawaf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2009222159170.3336@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=aaron.ma@canonical.com \
--cc=admin@kryma.net \
--cc=andriy.shevchenko@linux.intel.com \
--cc=benjamin.tissoires@redhat.com \
--cc=hdegoede@redhat.com \
--cc=hn.chen@weidahitech.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=kai.heng.feng@canonical.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=sultan@kerneltoast.com \
--cc=vicamo.yang@canonical.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).