From: Jiri Kosina <jikos@kernel.org>
To: Luke D Jones <luke@ljones.dev>
Cc: benjamin.tissoires@redhat.com, linux-kernel@vger.kernel.org,
linux-input@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH V6 RESEND] HID: ASUS: Add support for ASUS N-Key keyboard
Date: Fri, 9 Oct 2020 11:38:55 +0200 (CEST) [thread overview]
Message-ID: <nycvar.YFH.7.76.2010091137510.3336@cbobk.fhfr.pm> (raw)
In-Reply-To: <20200923215633.209724-1-luke@ljones.dev>
On Thu, 24 Sep 2020, Luke D Jones wrote:
> The ASUS N-Key keyboard uses the productId of 0x1866 and is used in
> almost all modern ASUS gaming laptops with slight changes to the
> firmware. This patch enables: Fn+key hotkeys, keyboard backlight
> brightness control, and notify asus-wmi to toggle "fan-mode".
>
> The keyboard has many of the same key outputs as the existing G752
> keyboard including a few extras, and varies a little between laptop
> models. The key-sets have been split and sub-grouped so that there
> will not be conflict between key event codes used.
>
> An existing key event used across some keyboards for "Mic Toggle"
> has been changed to emit "F20" as this is what all the main
> desktop environments are using.
>
> Additionally this keyboard requires the LED interface to be
> intitialised before such things as keyboard backlight control work.
>
> Misc changes in scope: update some hardcoded comparisons to use an
> available define.
>
> Signed-off-by: Luke D Jones <luke@ljones.dev>
Thanks for the patch. Looks good to me in general, one small nit before
this can be merged as a whole ...
> ---
> drivers/hid/hid-asus.c | 188 ++++++++++++++++++---
> drivers/hid/hid-ids.h | 1 +
> include/linux/platform_data/x86/asus-wmi.h | 2 +
... I'd like to get Ack from Andy (CCing) on the addition below to
asus-wmi.h.
[ ... snip ... ]
> diff --git a/include/linux/platform_data/x86/asus-wmi.h b/include/linux/platform_data/x86/asus-wmi.h
> index 897b8332a39f..05253cfe786c 100644
> --- a/include/linux/platform_data/x86/asus-wmi.h
> +++ b/include/linux/platform_data/x86/asus-wmi.h
> @@ -27,6 +27,8 @@
> #define ASUS_WMI_METHODID_INIT 0x54494E49 /* INITialize */
> #define ASUS_WMI_METHODID_HKEY 0x59454B48 /* Hot KEY ?? */
>
> +#define ASUS_WMI_METHODID_NOTIF 0x00100021 /* Notify method ?? */
> +
> #define ASUS_WMI_UNSUPPORTED_METHOD 0xFFFFFFFE
>
> /* Wireless */
Thanks,
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2020-10-09 9:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-23 21:56 [PATCH V6 RESEND] HID: ASUS: Add support for ASUS N-Key keyboard Luke D Jones
2020-10-08 9:33 ` Luke Jones
2020-10-09 9:38 ` Jiri Kosina [this message]
2020-10-09 13:14 ` Andy Shevchenko
2020-10-09 13:37 ` Hans de Goede
2020-10-09 14:03 ` Andy Shevchenko
2020-10-09 14:22 ` Hans de Goede
2020-10-11 7:05 ` Luke Jones
2020-10-12 9:51 ` Hans de Goede
2020-10-12 10:14 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2010091137510.3336@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=benjamin.tissoires@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luke@ljones.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).