From: Jiri Kosina <jikos@kernel.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-input@vger.kernel.org
Subject: Re: [PATCH] HID: ite: Replace ABS_MISC 120/121 events with touchpad on/off keypresses
Date: Thu, 22 Oct 2020 13:42:54 +0200 (CEST) [thread overview]
Message-ID: <nycvar.YFH.7.76.2010221342450.18859@cbobk.fhfr.pm> (raw)
In-Reply-To: <20201019074814.17722-1-hdegoede@redhat.com>
On Mon, 19 Oct 2020, Hans de Goede wrote:
> The usb-hid keyboard-dock for the Acer Switch 10 SW5-012 model declares
> an application and hid-usage page of 0x0088 for the INPUT(4) report which
> it sends. This reports contains 2 8-bit fields which are declared as
> HID_MAIN_ITEM_VARIABLE.
>
> The keyboard-touchpad combo never actually generates this report, except
> when the touchpad is toggled on/off with the Fn + F7 hotkey combo. The
> toggle on/off is handled inside the keyboard-dock, when the touchpad is
> toggled off it simply stops sending events.
>
> When the touchpad is toggled on/off an INPUT(4) report is generated with
> the first content byte set to 120/121, before this commit the kernel
> would report this as ABS_MISC 120/121 events.
>
> Patch the descriptor to replace the HID_MAIN_ITEM_VARIABLE with
> HID_MAIN_ITEM_RELATIVE (because no key-presss release events are send)
> and add mappings for the 0x00880078 and 0x00880079 usages to generate
> touchpad on/off key events when the touchpad is toggled on/off.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Applied, thanks.
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2020-10-22 11:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 7:48 [PATCH] HID: ite: Replace ABS_MISC 120/121 events with touchpad on/off keypresses Hans de Goede
2020-10-22 11:42 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2010221342450.18859@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=hdegoede@redhat.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).