linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Kosina <jikos@kernel.org>
To: Roderick Colenbrander <roderick@gaikai.com>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	linux-input@vger.kernel.org,
	Roderick Colenbrander <roderick.colenbrander@sony.com>
Subject: Re: [PATCH 0/3] HID: sony: various DS4 improvements
Date: Wed, 25 Nov 2020 13:55:10 +0100 (CET)	[thread overview]
Message-ID: <nycvar.YFH.7.76.2011251354360.3441@cbobk.fhfr.pm> (raw)
In-Reply-To: <20201110072229.9112-1-roderick@gaikai.com>

On Mon, 9 Nov 2020, Roderick Colenbrander wrote:

> From: Roderick Colenbrander <roderick.colenbrander@sony.com>
> 
> Hi,
> 
> This patch series provides a number of independent DS4 driver
> improvements.
> 
> The first patch improves DS4 battery level and battery status
> reporting. The current implementation interpreted the value
> ranges and status levels incorrectly.
> 
> The second patch fixes a DS4 dongle kernel crash (bug 206785).
> The specific problem is related to Steam, which implements
> its own user-space DS4 driver using hidraw. It collides during
> DS4 dongle hotplug, causing 'out of order HID feature reports'.
> The driver didn't expect this and this led to a kernel crash
> later on due to interpreting data incorrectly. The workaround
> is checking if the right data was returned and retrying.
> Though, I really really dislike this type of fix. Long-term
> some solution is needed to perhaps prevent hidraw and evdev
> drivers to step on each other's toes. For now this fixes
> the current problem.
> 
> The last patch fixes sysfs cleanup issues encountered using
> the DS4 dongle.

Hi Roderick,

I've applied the kernel crash fix to for-5.10/upstream-fixes and remaining 
two to for-5.11/sony.

Thanks,

-- 
Jiri Kosina
SUSE Labs


      parent reply	other threads:[~2020-11-25 12:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-10  7:22 [PATCH 0/3] HID: sony: various DS4 improvements Roderick Colenbrander
2020-11-10  7:22 ` [PATCH 1/3] HID: sony: Report more accurate DS4 power status Roderick Colenbrander
2020-11-10  7:22 ` [PATCH 2/3] HID: sony: Workaround for DS4 dongle hotplug kernel crash Roderick Colenbrander
2020-11-10  7:22 ` [PATCH 3/3] HID: sony: Don't use fw_version/hw_version for sysfs cleanup Roderick Colenbrander
2020-11-25 12:55 ` Jiri Kosina [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=nycvar.YFH.7.76.2011251354360.3441@cbobk.fhfr.pm \
    --to=jikos@kernel.org \
    --cc=benjamin.tissoires@redhat.com \
    --cc=linux-input@vger.kernel.org \
    --cc=roderick.colenbrander@sony.com \
    --cc=roderick@gaikai.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).