From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07EE1C56202 for ; Wed, 25 Nov 2020 13:18:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 93B75206F7 for ; Wed, 25 Nov 2020 13:18:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="IqK18eKt" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729153AbgKYNSL (ORCPT ); Wed, 25 Nov 2020 08:18:11 -0500 Received: from mail.kernel.org ([198.145.29.99]:53832 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726422AbgKYNSK (ORCPT ); Wed, 25 Nov 2020 08:18:10 -0500 Received: from pobox.suse.cz (nat1.prg.suse.com [195.250.132.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 41344206E5; Wed, 25 Nov 2020 13:18:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606310290; bh=J9gO+WXJ4CAYXF2VqrRZILd+9qWaibHE2TyAtPX5gyM=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=IqK18eKtowgWvbkaZid+fZL1VztUCibnpEpeAfbPikkhXZwYbtrVRG0KoYGL7RLuH 2+PvOcCx75Kclc8kH02z6+NSJTYxHYYM+NtB5TKzoaVvWnz+pzloM5DD6lOES7WxID hKbdskIY8Sn7C8NP2SOZtFQsw4oN5E+IF9jEiCSE= Date: Wed, 25 Nov 2020 14:18:07 +0100 (CET) From: Jiri Kosina To: Rikard Falkeborn cc: Benjamin Tissoires , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] HID: wacom: Constify attribute_groups In-Reply-To: <20201124230109.67543-1-rikard.falkeborn@gmail.com> Message-ID: References: <20201124230109.67543-1-rikard.falkeborn@gmail.com> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Wed, 25 Nov 2020, Rikard Falkeborn wrote: > These are never modified, so make them const to allow the compiler to put > them in read-only memory. It also allows the compiler to shrink the > resulting module with ~900 bytes, test-built with gcc 10.2 on x86_64. > > text data bss dec hex filename > 204377 42832 576 247785 3c7e9 drivers/hid/wacom_old.ko > 204240 42064 576 246880 3c460 drivers/hid/wacom_new.ko Applied, thanks Rikard. -- Jiri Kosina SUSE Labs