From: Jiri Kosina <jikos@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Douglas Anderson <dianders@chromium.org>,
"open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 4/4] HID: i2c-hid: acpi: Drop redundant ACPI_PTR()
Date: Mon, 8 Mar 2021 10:45:57 +0100 (CET) [thread overview]
Message-ID: <nycvar.YFH.7.76.2103081045440.12405@cbobk.fhfr.pm> (raw)
In-Reply-To: <YD0S7U9CKHf5rKr6@smile.fi.intel.com>
On Mon, 1 Mar 2021, Andy Shevchenko wrote:
> > > > The driver depends on ACPI, ACPI_PTR() resolution is always the same.
> > > > Otherwise a compiler may produce a warning.
> > > >
> > > > That said, the rule of thumb either ugly ifdeffery with ACPI_PTR or
> > > > none should be used in a driver.
> > > >
> > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > >
> > > Thanks a lot for the series. This indeed cleans things up.
> >
> > Indeed, thanks.
> >
> > > For the series:
> > > Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> > >
> > > Jiri, I wonder where we want to land this one. This is not strictly
> > > bug fixes, but we could definitively sneak this one in 5.12-rc1.
> > > Well, I should probably run the series on an acpi laptop here before
> > > merging, but I'd like to know if delaying to 5.13 is OK or if we need
> > > this in 5.12.
> >
> > I'd like to do it the standard way and have it bake in for-next to see if
> > it really doesn't break anything, so unless there are convicing arguments
> > for 5.12-rcX, I'd rathre queue this for 5.13.
>
> For the record, I'm not in hurry with this, up to you how to proceed.
> Thanks!
Queued in for-5.13/i2c-hid. Thanks,
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2021-03-08 9:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-26 19:32 [PATCH v2 1/4] HID: i2c-hid: acpi: Get ACPI companion only once and reuse it Andy Shevchenko
2021-02-26 19:32 ` [PATCH v2 2/4] HID: i2c-hid: acpi: Switch to new style i2c-driver probe function Andy Shevchenko
2021-02-26 19:32 ` [PATCH v2 3/4] HID: i2c-hid: acpi: Move GUID out of function and described it Andy Shevchenko
2021-02-26 19:32 ` [PATCH v2 4/4] HID: i2c-hid: acpi: Drop redundant ACPI_PTR() Andy Shevchenko
2021-03-01 14:38 ` Benjamin Tissoires
2021-03-01 15:34 ` Jiri Kosina
2021-03-01 16:14 ` Andy Shevchenko
2021-03-08 9:45 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2103081045440.12405@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=benjamin.tissoires@redhat.com \
--cc=dianders@chromium.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).