From: Jiri Kosina <jikos@kernel.org>
To: Douglas Gilbert <dgilbert@interlog.com>
Cc: linux-input@vger.kernel.org, linux-usb@vger.kernel.org,
benjamin.tissoires@redhat.com
Subject: Re: [PATCH] [input]: hid-cp2112: fix multiple gpiochips
Date: Mon, 8 Mar 2021 14:56:03 +0100 (CET) [thread overview]
Message-ID: <nycvar.YFH.7.76.2103081455520.12405@cbobk.fhfr.pm> (raw)
In-Reply-To: <20210109223658.749743-1-dgilbert@interlog.com>
On Sat, 9 Jan 2021, Douglas Gilbert wrote:
> In lk 5.11.0-rc2 connecting a USB based Silicon Labs HID to I2C
> bridge evaluation board (CP2112EK) causes this warning:
> gpio gpiochip0: (cp2112_gpio): detected irqchip that is shared
> with multiple gpiochips: please fix the driver
>
> Simply copy what other gpio related drivers do to fix this
> particular warning: replicate the struct irq_chip object in each
> device instance rather than have a static object which makes that
> object (incorrectly) shared by each device.
>
> Signed-off-by: Douglas Gilbert <dgilbert@interlog.com>
Applied, thanks for the fix, and sorry for the delay.
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2021-03-08 13:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-09 22:36 [PATCH] [input]: hid-cp2112: fix multiple gpiochips Douglas Gilbert
2021-03-08 13:56 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2103081455520.12405@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=dgilbert@interlog.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).