From: Jiri Kosina <jikos@kernel.org>
To: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: "Uwe Kleine-König" <uwe@kleine-koenig.org>,
"Benjamin Tissoires" <benjamin.tissoires@redhat.com>,
"Enric Balletbo i Serra" <enric.balletbo@collabora.com>,
"Guenter Roeck" <groeck@chromium.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/3] HID: intel-ish-hid: Drop if block with an always false condition
Date: Mon, 8 Mar 2021 17:16:54 +0100 (CET) [thread overview]
Message-ID: <nycvar.YFH.7.76.2103081716200.12405@cbobk.fhfr.pm> (raw)
In-Reply-To: <31028f589e27e246bb3b4b693caeb0b8eae3a285.camel@linux.intel.com>
On Mon, 8 Mar 2021, Srinivas Pandruvada wrote:
> > > A remove callback is only ever called for a bound device. So there
> > > is no
> > > need to check for device or driver being NULL.
> >
> > Srinivas, any objections to this patchset? The cleanups look good to
> > me.
> Sorry, I missed this series.
> No objection for taking these patches.
Thanks. Applied with your Acked-by:
If you disagree with that interpretation of your statement above, please
holler :)
Thanks,
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2021-03-08 16:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-06 15:13 [PATCH v1 1/3] HID: intel-ish-hid: Drop if block with an always false condition Uwe Kleine-König
2021-02-06 15:13 ` [PATCH v1 2/3] HID: intel-ish-hid: Simplify logic in ishtp_cl_device_remove() Uwe Kleine-König
2021-02-06 15:13 ` [PATCH v1 3/3] HID: intel-ish-hid: Make remove callback return void Uwe Kleine-König
2021-03-08 10:07 ` [PATCH v1 1/3] HID: intel-ish-hid: Drop if block with an always false condition Jiri Kosina
2021-03-08 16:03 ` Srinivas Pandruvada
2021-03-08 16:16 ` Jiri Kosina [this message]
2021-03-08 16:35 ` Srinivas Pandruvada
2021-05-10 19:43 ` Uwe Kleine-König
2021-05-13 11:20 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2103081716200.12405@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=enric.balletbo@collabora.com \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@chromium.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=uwe@kleine-koenig.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).