From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70AC1C004D4 for ; Wed, 18 Jan 2023 10:08:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229754AbjARKI0 (ORCPT ); Wed, 18 Jan 2023 05:08:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43536 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230205AbjARKHq (ORCPT ); Wed, 18 Jan 2023 05:07:46 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 616F3654E2 for ; Wed, 18 Jan 2023 01:12:59 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9BBA3B8118F for ; Wed, 18 Jan 2023 09:12:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4FFB0C433EF; Wed, 18 Jan 2023 09:12:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674033177; bh=DO1Dt5nQfX6tZZ1TlahNOJYkSC3Y16RF4bghgdpXtls=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=okOEjI/sN92SfZUHciseN4ht7SUvm4Y2Ydy+7d2Dbe9f8TZBgLUBCONR/3aDTPbvH RNptWW1IYKj5+nXrYN8rhmQ5DxfzX+k7Iz/AiKGBaFv6bmGN0ey9M/Kn0JLpmVi88a XDuN73BbFNJz+8NxPnUXARLE2t4gjaslFq+20MyvF3dfw+Wq0QVMysl8kCjR9LRHIf 09iCq/GMWTYZYQdtE8XoCZFYI4TcBjP2DfrNuB4nq+1iRqB+VKNJN6FT4+ABCw7Gu/ dEo8wtonujnXMn6Ot03lJsVR4zKFj3gU5tshWmkAP0P4BdJsg+nuR214plkhAQyOXw 3n/bQbNMLTtiA== Date: Wed, 18 Jan 2023 10:12:58 +0100 (CET) From: Jiri Kosina To: Roderick Colenbrander cc: Benjamin Tissoires , linux-input@vger.kernel.org, Roderick Colenbrander Subject: Re: [PATCH 5/5] HID: playstation: correct DualSense gyro bias handling. In-Reply-To: <20230106015910.3031670-6-roderick.colenbrander@sony.com> Message-ID: References: <20230106015910.3031670-1-roderick.colenbrander@sony.com> <20230106015910.3031670-6-roderick.colenbrander@sony.com> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Thu, 5 Jan 2023, Roderick Colenbrander wrote: > The bias for the gyroscope is not used correctly. The sensor bias > needs to be used in calculation of the 'sensivity' instead of being > an offset. > > In practice this has little input on the values as the bias values > tends to be small (+/- 20). > > Signed-off-by: Roderick Colenbrander Applied to for-6.3/sony. -- Jiri Kosina SUSE Labs