From: Mimi Zohar <zohar@linux.ibm.com>
To: Vitaly Chikunov <vt@altlinux.org>,
Thiago Jung Bauermann <bauerman@linux.ibm.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
David Howells <dhowells@redhat.com>,
linux-integrity@vger.kernel.org, keyrings@vger.kernel.org,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
Dmitry Kasatkin <dmitry.kasatkin@gmail.com>
Subject: Re: [PATCH v5 10/10] integrity: support EC-RDSA signatures for asymmetric_verify
Date: Tue, 26 Feb 2019 07:07:43 -0500 [thread overview]
Message-ID: <1551182863.27819.62.camel@linux.ibm.com> (raw)
In-Reply-To: <20190226042546.czh6me47f7xldgk2@altlinux.org>
> > > diff --git a/security/integrity/digsig_asymmetric.c b/security/integrity/digsig_asymmetric.c
> > > index d775e03fbbcc..c4a3313e0210 100644
> > > --- a/security/integrity/digsig_asymmetric.c
> > > +++ b/security/integrity/digsig_asymmetric.c
> > > @@ -104,9 +104,14 @@ int asymmetric_verify(struct key *keyring, const char *sig,
> > >
> > > memset(&pks, 0, sizeof(pks));
> > >
> > > - pks.pkey_algo = "rsa";
> > > pks.hash_algo = hash_algo_name[hdr->hash_algo];
> > > - pks.encoding = "pkcs1";
> > > + if (!strncmp(pks.hash_algo, "streebog", 8)) {
> >
> > Is it possible to test hdr->hash_algo instead of pkcs.hash_algo? IMHO if
> > an integer value is available it's preferable to check it rather than
> > doing a string comparison.
>
> Yes. But we have long tradition of comparing by the name too:
>
> --linux$ git grep str.*cmp.*'"sha[12]'
> drivers/crypto/mxs-dcp.c: if (strcmp(halg->base.cra_name, "sha1") == 0)
> drivers/crypto/talitos.c: (!strcmp(alg->cra_name, "sha224") ||
> net/sctp/sysctl.c: if (!strncmp(tmp, "sha1", 4)) {
> scripts/sign-file.c: if (strcmp(hash_algo, "sha1") != 0) {
sign_file.c is a userspace program used for signing kernel modules.
This example is not applicable.
> security/integrity/ima/ima_main.c: if (strncmp(str, "sha1", 4) == 0)
In the ima_main.c example, it is used in an __init function to set up
crypto defaults. The code also predates the enumerations defined in
crypto/hash_info.c.
Mimi
next prev parent reply other threads:[~2019-02-26 12:08 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-24 6:08 [PATCH v5 00/10] crypto: add EC-RDSA (GOST 34.10) algorithm Vitaly Chikunov
2019-02-24 6:08 ` [PATCH v5 01/10] KEYS: report to keyctl only actually supported key ops Vitaly Chikunov
2019-02-24 6:08 ` [PATCH v5 02/10] crypto: akcipher - check the presence of callback before the call Vitaly Chikunov
2019-02-24 6:08 ` [PATCH v5 03/10] crypto: rsa - unimplement sign/verify for raw RSA backends Vitaly Chikunov
2019-02-24 6:08 ` [PATCH v5 04/10] crypto: akcipher - new verify API for public key algorithms Vitaly Chikunov
2019-02-27 23:28 ` Mimi Zohar
2019-02-28 5:37 ` Vitaly Chikunov
2019-02-24 6:08 ` [PATCH v5 05/10] X.509: parse public key parameters from x509 for akcipher Vitaly Chikunov
2019-02-24 6:08 ` [PATCH v5 06/10] crypto: Kconfig - create Public-key cryptography section Vitaly Chikunov
2019-02-24 6:08 ` [PATCH v5 07/10] crypto: ecc - make ecc into separate module Vitaly Chikunov
2019-02-24 6:08 ` [PATCH v5 08/10] crypto: ecrdsa - add EC-RDSA (GOST 34.10) algorithm Vitaly Chikunov
2019-02-24 6:08 ` [PATCH v5 09/10] crypto: ecrdsa - add EC-RDSA test vectors to testmgr Vitaly Chikunov
2019-02-24 6:08 ` [PATCH v5 10/10] integrity: support EC-RDSA signatures for asymmetric_verify Vitaly Chikunov
2019-02-25 21:20 ` Thiago Jung Bauermann
2019-02-26 4:25 ` Vitaly Chikunov
2019-02-26 12:07 ` Mimi Zohar [this message]
2019-02-28 18:18 ` [PATCH v5 04/10] crypto: akcipher - new verify API for public key algorithms David Howells
2019-02-28 18:39 ` Vitaly Chikunov
2019-02-28 19:02 ` David Howells
2019-02-28 19:07 ` Vitaly Chikunov
2019-03-01 2:34 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1551182863.27819.62.camel@linux.ibm.com \
--to=zohar@linux.ibm.com \
--cc=bauerman@linux.ibm.com \
--cc=dhowells@redhat.com \
--cc=dmitry.kasatkin@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vt@altlinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).