From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49FBBC43381 for ; Wed, 20 Mar 2019 01:21:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1BA3821841 for ; Wed, 20 Mar 2019 01:21:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726823AbfCTBVJ (ORCPT ); Tue, 19 Mar 2019 21:21:09 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:32990 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726937AbfCTBVJ (ORCPT ); Tue, 19 Mar 2019 21:21:09 -0400 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x2K1EQvN118400 for ; Tue, 19 Mar 2019 21:21:07 -0400 Received: from e06smtp02.uk.ibm.com (e06smtp02.uk.ibm.com [195.75.94.98]) by mx0b-001b2d01.pphosted.com with ESMTP id 2rbbpc06f1-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 19 Mar 2019 21:21:07 -0400 Received: from localhost by e06smtp02.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 20 Mar 2019 01:21:01 -0000 Received: from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196) by e06smtp02.uk.ibm.com (192.168.101.132) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 20 Mar 2019 01:20:57 -0000 Received: from d06av24.portsmouth.uk.ibm.com (d06av24.portsmouth.uk.ibm.com [9.149.105.60]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x2K1L0Yl33488980 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 20 Mar 2019 01:21:00 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 062554203F; Wed, 20 Mar 2019 01:21:00 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3A93142045; Wed, 20 Mar 2019 01:20:58 +0000 (GMT) Received: from localhost.localdomain (unknown [9.80.93.235]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 20 Mar 2019 01:20:58 +0000 (GMT) Subject: Re: [PATCH 0/6] security/keys/encrypted: Break module dependency chain From: Mimi Zohar To: James Bottomley , Dan Williams , keyrings@vger.kernel.org Cc: Ira Weiny , Dave Jiang , Tyler Hicks , Keith Busch , Jarkko Sakkinen , David Howells , Vishal Verma , linux-integrity@vger.kernel.org, ecryptfs@vger.kernel.org, Roberto Sassu , linux-nvdimm , Linux Kernel Mailing List Date: Tue, 19 Mar 2019 21:20:47 -0400 In-Reply-To: <1553029714.2932.43.camel@linux.ibm.com> References: <155297557534.2276575.16264199708584900090.stgit@dwillia2-desk3.amr.corp.intel.com> <1553029714.2932.43.camel@linux.ibm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 19032001-0008-0000-0000-000002CF5617 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19032001-0009-0000-0000-0000223B6B20 Message-Id: <1553044847.4899.169.camel@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-03-20_01:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1903200006 Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Tue, 2019-03-19 at 14:08 -0700, James Bottomley wrote: > On Tue, 2019-03-19 at 14:01 -0700, Dan Williams wrote: > > On Mon, Mar 18, 2019 at 11:18 PM Dan Williams > om> wrote: > > > > > > With v5.1-rc1 all the nvdimm sub-system regression tests started > > > failing because the libnvdimm module failed to load in the qemu-kvm > > > test environment. Critically that environment does not have a TPM. > > > Commit 240730437deb "KEYS: trusted: explicitly use tpm_chip > > > structure..." started to require a TPM to be present for the > > > trusted.ko module to load where there was no requirement for that > > > before. > > > > > > Rather than undo the "fail if no hardware" behavior James points > > > out that the module dependencies can be broken by looking up the > > > key-type by name. Remove the dependencies on the "key_type_trusted" > > > and "key_type_encrypted" symbol exports, and clean up other > > > boilerplate that supported those exports in different > > > configurations. > > > > Any feedback? Was hoping to get at least patch1 in the queue for > > v5.1-rc2 since this effectively disables the nvdimm driver on typical > > configurations. Jarkko, would you be willing to merge it since the > > regression came through your tree? > > The reason I sent out the RFC was to see if the people who actually > wrote the code had any reasons they needed the current way of doing > things preserving. No, it looks fine.  The error return codes will change, but I don't think that is a problem. Mimi > > I think your series looks fine except you need to export > key_type_lookup (patch 2) before you use it (patch 1) to preserve > bisectability of builds. > > James