From: James Bottomley <jejb@linux.ibm.com>
To: Mimi Zohar <zohar@linux.ibm.com>,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org,
keyrings@vger.kernel.org, Mimi Zohar <zohar@us.ibm.com>,
David Howells <dhowells@redhat.com>,
James Morris <jmorris@namei.org>,
Denis Kenzior <denkenz@gmail.com>,
Marcel Holtmann <marcel@holtmann.org>,
James Morris <james.morris@microsoft.com>
Subject: Re: Bad file pattern in MAINTAINERS section 'KEYS-TRUSTED'
Date: Tue, 26 Mar 2019 07:25:17 -0700 [thread overview]
Message-ID: <1553610317.2900.2.camel@linux.ibm.com> (raw)
In-Reply-To: <1553602220.3960.29.camel@linux.ibm.com>
On Tue, 2019-03-26 at 08:10 -0400, Mimi Zohar wrote:
> Hi Jarrko,
>
> On Tue, 2019-03-26 at 13:37 +0200, Jarkko Sakkinen wrote:
> > Mimi,
> >
> > Can you fix this and I can ack and send PR through my tree?
>
> Making the "trusted.h" include file public was part of David's "KEYS:
> Support TPM-wrapped key and crypto ops" patch set. I wasn't involved
> in reviewing or upstreaming this patch set. As I recall, it was
> upstreamed rather quickly without much review. As it is TPM related,
> it should have at least been posted on the linux-integrity mailing
> list. I have no idea if "trusted.h" should have been made public.
>
> I'm not sure just "fixing" the MAINTAINERS file is the right
> solution. I was hoping to look at it later this week. Perhaps you
> and James could take a look?
Looking at the contents of linux/keys/trusted.h, it looks like the
wrong decision to move it. The contents are way too improperly named
and duplicative to be in a standard header. It's mostly actually TPM
code including a redefinition of the tpm_buf structure, so it doesn't
even seem to be necessary for trusted keys.
If you want to fix this as a bug, I'd move it back again, but long term
I think it should simply be combined with trusted.c because nothing
else can include it sanely anyway.
James
next prev parent reply other threads:[~2019-03-26 14:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <7cd8d12f59bcacd18a78f599b46dac555f7f16c0.camel@perches.com>
2019-03-25 21:27 ` Bad file pattern in MAINTAINERS section 'KEYS-TRUSTED' Joe Perches
2019-03-26 11:37 ` Jarkko Sakkinen
2019-03-26 12:10 ` Mimi Zohar
2019-03-26 14:25 ` James Bottomley [this message]
2019-03-26 14:59 ` Denis Kenzior
2019-03-26 16:25 ` James Bottomley
2019-03-27 4:58 ` Jarkko Sakkinen
2019-03-27 4:54 ` Jarkko Sakkinen
2019-08-13 6:57 ` Denis Efremov
2019-08-15 21:57 ` Jarkko Sakkinen
2019-08-15 22:12 ` [RESEND PATCH] MAINTAINERS: keys: Update path to trusted.h Denis Efremov
2019-08-16 18:58 ` Jarkko Sakkinen
2019-09-10 11:50 ` Denis Efremov
2019-09-14 13:50 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1553610317.2900.2.camel@linux.ibm.com \
--to=jejb@linux.ibm.com \
--cc=denkenz@gmail.com \
--cc=dhowells@redhat.com \
--cc=james.morris@microsoft.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jmorris@namei.org \
--cc=joe@perches.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=zohar@linux.ibm.com \
--cc=zohar@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).