From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A602C3A5A6 for ; Wed, 28 Aug 2019 13:50:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DF8DD22CF8 for ; Wed, 28 Aug 2019 13:50:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726382AbfH1NuY (ORCPT ); Wed, 28 Aug 2019 09:50:24 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:64038 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726439AbfH1NuY (ORCPT ); Wed, 28 Aug 2019 09:50:24 -0400 Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x7SDdxlX115472 for ; Wed, 28 Aug 2019 09:50:23 -0400 Received: from e06smtp02.uk.ibm.com (e06smtp02.uk.ibm.com [195.75.94.98]) by mx0a-001b2d01.pphosted.com with ESMTP id 2unrh35x3v-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 28 Aug 2019 09:50:23 -0400 Received: from localhost by e06smtp02.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 28 Aug 2019 14:50:20 +0100 Received: from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197) by e06smtp02.uk.ibm.com (192.168.101.132) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 28 Aug 2019 14:50:18 +0100 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x7SDoHIf58327210 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 28 Aug 2019 13:50:17 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6E4A74C04A; Wed, 28 Aug 2019 13:50:17 +0000 (GMT) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 996804C04E; Wed, 28 Aug 2019 13:50:15 +0000 (GMT) Received: from localhost.localdomain (unknown [9.85.129.156]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 28 Aug 2019 13:50:15 +0000 (GMT) Subject: Re: [PATCH][next] ima: ima_modsig: Fix use-after-free bug in ima_read_modsig From: Mimi Zohar To: "Gustavo A. R. Silva" , Dmitry Kasatkin , James Morris , "Serge E. Hallyn" , Thiago Jung Bauermann Cc: linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 28 Aug 2019 09:50:15 -0400 In-Reply-To: <20190811235507.GA9587@embeddedor> References: <20190811235507.GA9587@embeddedor> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 19082813-0008-0000-0000-0000030E46EB X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19082813-0009-0000-0000-00004A2C8752 Message-Id: <1567000215.6115.19.camel@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-08-28_06:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908280144 Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org Hi Gustavo, On Sun, 2019-08-11 at 18:55 -0500, Gustavo A. R. Silva wrote: > hdr is being freed and then dereferenced by accessing hdr->pkcs7_msg > > Fix this by copying the value returned by PTR_ERR(hdr->pkcs7_msg) into > automatic variable err for its safe use after freeing hdr. > > Addresses-Coverity-ID: 1485813 ("Read from pointer after free") > Fixes: 39b07096364a ("ima: Implement support for module-style appended signatures") > Signed-off-by: Gustavo A. R. Silva This bug was reported Julia and addressed by Thiago on 8/7. If you would like to add your Review/Tested-by, the patch can be found in the linux-integrity next-queued-testing branch. thanks, Mimi