From: Mimi Zohar <zohar@linux.ibm.com>
To: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>,
Sasha Levin <sashal@kernel.org>
Cc: linux-integrity@vger.kernel.org,
Matthew Garrett <mjg59@google.com>,
jamorris@linux.microsoft.com, kgoldman@us.ibm.com, "Wiseman,
Monty (GE Global Research, US)" <monty.wiseman@ge.com>,
Roberto Sassu <roberto.sassu@huawei.com>,
Greg KH <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 0/1] KEYS: Measure keys in trusted keyring
Date: Fri, 04 Oct 2019 17:58:07 -0400 [thread overview]
Message-ID: <1570226287.5046.114.camel@linux.ibm.com> (raw)
In-Reply-To: <868f6b82-7b43-5e27-0738-f9d09e765c59@linux.microsoft.com>
On Fri, 2019-10-04 at 13:10 -0700, Lakshmi Ramasubramanian wrote:
> On 10/4/19 12:57 PM, Mimi Zohar wrote:
>
> >
> > IMA is late because it is waiting for the TPM to be available.
> >
> > Another option would be to queue the measurements and then replay
> > them once the TPM and IMA are available.
> >
> > I'm not sure I like this approach any better.
>
> I agree - I too don't like this approach (queue the measurements and
> then replay). Even in that approach IMA will have to invoke functions
> outside of IMA to retrieve the stored measurements.
The measurements could be added to an IMA pending measurement
workqueue, until the TPM is enabled, assuming there is a TPM, and then
processed. All of this code would be within IMA.
>
> I prefer gathering data on trusted keys in ima_init, but gate it by IMA
> policy and follow the other coding guidelines you have suggested earlier
> (similar to the approach taken for kexec_cmdline measurement).
So your intention is only to measure the initial keys added to these
keyrings, not anything subsequently added to the secondary keyring?
> Please let me know if you agree - I can send the new patch set by next week.
Defining an LSM/IMA hook to measure keys, based on policy, seems
cleaner and more useful.
Mimi
next prev parent reply other threads:[~2019-10-04 21:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 0:27 [PATCH 0/1] KEYS: Measure keys in trusted keyring Lakshmi Ramasubramanian
2019-08-28 0:27 ` [PATCH 1/1] " Lakshmi Ramasubramanian
2019-09-02 22:04 ` Mimi Zohar
2019-08-29 1:11 ` [PATCH 0/1] " Mimi Zohar
2019-08-30 2:43 ` Lakshmi Ramasubramanian
2019-08-30 18:41 ` Mimi Zohar
2019-09-03 15:54 ` Lakshmi Ramasubramanian
2019-09-09 13:31 ` Mimi Zohar
2019-09-09 21:34 ` James Morris
2019-09-19 13:18 ` Sasha Levin
2019-09-19 17:12 ` Mimi Zohar
2019-10-04 19:29 ` Lakshmi Ramasubramanian
2019-10-04 19:57 ` Mimi Zohar
2019-10-04 20:10 ` Lakshmi Ramasubramanian
2019-10-04 21:58 ` Mimi Zohar [this message]
2019-10-05 0:10 ` Lakshmi Ramasubramanian
2019-10-06 13:17 ` Mimi Zohar
2019-10-07 15:03 ` Lakshmi Ramasubramanian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1570226287.5046.114.camel@linux.ibm.com \
--to=zohar@linux.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=jamorris@linux.microsoft.com \
--cc=kgoldman@us.ibm.com \
--cc=linux-integrity@vger.kernel.org \
--cc=mjg59@google.com \
--cc=monty.wiseman@ge.com \
--cc=nramas@linux.microsoft.com \
--cc=roberto.sassu@huawei.com \
--cc=sashal@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).