From: Mimi Zohar <zohar@linux.ibm.com>
To: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>,
linux-integrity@vger.kernel.org
Cc: eric.snowberg@oracle.com, dhowells@redhat.com,
matthewgarrett@google.com, sashal@kernel.org,
jamorris@linux.microsoft.com, linux-kernel@vger.kernel.org,
keyrings@vger.kernel.org,
Janne Karhunen <janne.karhunen@gmail.com>
Subject: Re: [PATCH v0 1/2] IMA: Defined queue functions
Date: Mon, 02 Dec 2019 13:00:22 -0500 [thread overview]
Message-ID: <1575309622.4793.413.camel@linux.ibm.com> (raw)
In-Reply-To: <ea2fafb8-a97f-5365-debd-d90143e549bf@linux.microsoft.com>
On Wed, 2019-11-27 at 13:11 -0800, Lakshmi Ramasubramanian wrote:
> On 11/27/19 12:38 PM, Mimi Zohar wrote:
> > I'm not sure why you want to differentiate between IMA being
> > initialized vs. an empty policy. I would think you would want to know
> > when a custom policy has been loaded.
>
> You are right - When custom ima policy rules are loaded (in
> ima_update_policy() function), ima_process_queued_keys_for_measurement()
> function is called to process queued keys.
>
> The flag ima_process_keys_for_measurement is set to true in
> ima_process_queued_keys_for_measurement(). And, subsequent keys are
> processed immediately.
>
> Please take a look at ima_process_queued_keys_for_measurement() in this
> patch (v0 1/2) and the ima_update_policy() change in "PATCH v0 2/2".
ima_update_policy() is called from multiple places. Initially, it is
called before a custom policy has been loaded. The call to
ima_process_queued_keys_for_measurement() needs to be moved to within
the test, otherwise it runs the risk of dropping "key" measurements.
All the queued keys need to be processed at the same time. Afterwards
the queue should be deleted. Unfortunately, the current queue locking
assumes ima_process_queued_keys_for_measurement() is called multiple
times.
Perhaps using the RCU method of walking lists would help. I need to
think about it some more.
Mimi
next prev parent reply other threads:[~2019-12-02 18:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 2:52 [PATCH v0 0/2] IMA: Deferred measurement of keys Lakshmi Ramasubramanian
2019-11-27 2:52 ` [PATCH v0 1/2] IMA: Defined queue functions Lakshmi Ramasubramanian
2019-11-27 20:38 ` Mimi Zohar
2019-11-27 21:11 ` Lakshmi Ramasubramanian
2019-12-02 18:00 ` Mimi Zohar [this message]
2019-12-02 18:39 ` Lakshmi Ramasubramanian
2019-12-02 19:11 ` Mimi Zohar
2019-12-02 20:24 ` Lakshmi Ramasubramanian
2019-12-03 0:02 ` Mimi Zohar
2019-11-27 2:52 ` [PATCH v0 2/2] IMA: Call queue functions to measure keys Lakshmi Ramasubramanian
2019-12-03 0:02 ` Mimi Zohar
2019-12-03 16:09 ` Lakshmi Ramasubramanian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1575309622.4793.413.camel@linux.ibm.com \
--to=zohar@linux.ibm.com \
--cc=dhowells@redhat.com \
--cc=eric.snowberg@oracle.com \
--cc=jamorris@linux.microsoft.com \
--cc=janne.karhunen@gmail.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthewgarrett@google.com \
--cc=nramas@linux.microsoft.com \
--cc=sashal@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).