From: Mimi Zohar <zohar@linux.ibm.com>
To: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>,
kbuild test robot <lkp@intel.com>
Cc: kbuild-all@lists.01.org, linux-integrity@vger.kernel.org
Subject: Re: [RFC PATCH integrity] IMA: ima_queue_key() can be static
Date: Thu, 26 Dec 2019 09:27:57 -0500 [thread overview]
Message-ID: <1577370477.4487.11.camel@linux.ibm.com> (raw)
In-Reply-To: <c31a5f8b-2db9-f8ad-51f6-b6e471b05737@linux.microsoft.com>
On Tue, 2019-12-24 at 22:43 -0800, Lakshmi Ramasubramanian wrote:
> Hi Mimi,
>
> On 12/24/2019 8:54 PM, kbuild test robot wrote:
> >
> > Fixes: 466a4c055a9b ("IMA: Define workqueue for early boot "key" measurements")
> > Signed-off-by: kbuild test robot <lkp@intel.com>
> > ---
> > ima_asymmetric_keys.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > -bool ima_queue_key(struct key *keyring, const void *payload,
> > - size_t payload_len)
> > +static bool ima_queue_key(struct key *keyring, const void *payload,
> > + size_t payload_len)
> > {
> > bool queued = false;
> > struct ima_key_entry *entry;
> >
>
> I'd defined ima_queue_key() as non-static when it could have been
> defined as static.
>
> From this patch I understand this change is done. Is there anything I
> need to do to address this issue?
No, I'll squash this patch with the original patch, adding the
requested tags.
Mimi
next prev parent reply other threads:[~2019-12-26 14:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-25 4:54 [integrity:next-integrity-testing 3/5] security/integrity/ima/ima_asymmetric_keys.c:70:6: sparse: sparse: symbol 'ima_queue_key' was not declared. Should it be static? kbuild test robot
2019-12-25 4:54 ` [RFC PATCH integrity] IMA: ima_queue_key() can be static kbuild test robot
2019-12-25 6:43 ` Lakshmi Ramasubramanian
2019-12-26 14:27 ` Mimi Zohar [this message]
2019-12-26 18:33 ` Lakshmi Ramasubramanian
2019-12-26 14:27 ` [integrity:next-integrity-testing 3/5] security/integrity/ima/ima_asymmetric_keys.c:70:6: sparse: sparse: symbol 'ima_queue_key' was not declared. Should it be static? Mimi Zohar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1577370477.4487.11.camel@linux.ibm.com \
--to=zohar@linux.ibm.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-integrity@vger.kernel.org \
--cc=lkp@intel.com \
--cc=nramas@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).