From: Mimi Zohar <zohar@linux.ibm.com>
To: Florent Revest <revest@chromium.org>, KP Singh <kpsingh@chromium.org>
Cc: linux-integrity@vger.kernel.org, mjg59@google.com,
nramas@linux.microsoft.com, linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org,
Florent Revest <revest@google.com>
Subject: Re: [PATCH v2] ima: add the ability to query the hash of a given file.
Date: Wed, 15 Jan 2020 14:09:53 -0500 [thread overview]
Message-ID: <1579115393.5032.21.camel@linux.ibm.com> (raw)
In-Reply-To: <b88cbb1fb39175611e4b31e12a47df240a46dd48.camel@chromium.org>
On Wed, 2020-01-15 at 19:45 +0100, Florent Revest wrote:
> On Wed, 2020-01-15 at 13:36 -0500, Mimi Zohar wrote:
> > On Mon, 2020-01-13 at 11:48 +0100, KP Singh wrote:
> > > On 06-Jan 17:25, Florent Revest wrote:
> > > > From: Florent Revest <revest@google.com>
> > > >
> > > > This allows other parts of the kernel (perhaps a stacked LSM
> > > > allowing
> > > > system monitoring, eg. the proposed KRSI LSM [1]) to retrieve the
> > > > hash
> > > > of a given file from IMA if it's present in the iint cache.
> > > >
> > > > It's true that the existence of the hash means that it's also in
> > > > the
> > > > audit logs or in
> > > > /sys/kernel/security/ima/ascii_runtime_measurements,
> > > > but it can be difficult to pull that information out for every
> > > > subsequent exec. This is especially true if a given host has
> > > > been up
> > > > for a long time and the file was first measured a long time ago.
> > > >
> > > > This is based on Peter Moody's patch:
> > > > https://sourceforge.net/p/linux-ima/mailman/message/33036180/
> > > >
> > > > [1] https://lkml.org/lkml/2019/9/10/393
> > > >
> > > > Signed-off-by: Florent Revest <revest@google.com>
> > >
> > > Thanks for adding this Florent!
> > >
> > > Reviewed-by: KP Singh <kpsingh@chromium.org>
> >
> > Thanks, this patch is now queued in next-integrity-testing.
>
> Good to hear Mimi! Thank you.
>
> I would just like to make sure that you queued the v3 of this patch
> though...? (this thread is for the v2 :) ) The v3 includes a couple of
> comments you asked for.
Oops, yes v3 is queued.
Mimi
prev parent reply other threads:[~2020-01-15 19:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-06 16:25 [PATCH v2] ima: add the ability to query the hash of a given file Florent Revest
2020-01-08 16:05 ` Mimi Zohar
2020-01-13 9:42 ` Florent Revest
2020-01-13 10:48 ` KP Singh
2020-01-15 18:36 ` Mimi Zohar
2020-01-15 18:45 ` Florent Revest
2020-01-15 19:09 ` Mimi Zohar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1579115393.5032.21.camel@linux.ibm.com \
--to=zohar@linux.ibm.com \
--cc=kpsingh@chromium.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mjg59@google.com \
--cc=nramas@linux.microsoft.com \
--cc=revest@chromium.org \
--cc=revest@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).