From: Mimi Zohar <zohar@linux.ibm.com>
To: Tushar Sugandhi <tusharsu@linux.microsoft.com>,
joe@perches.com, skhan@linuxfoundation.org,
linux-integrity@vger.kernel.org
Cc: sashal@kernel.org, nramas@linux.microsoft.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/3] IMA: Add log statements for failure conditions.
Date: Wed, 12 Feb 2020 19:21:51 -0500 [thread overview]
Message-ID: <1581553311.8515.96.camel@linux.ibm.com> (raw)
In-Reply-To: <ce89d382-8e8b-71d0-5271-4db83d324f94@linux.microsoft.com>
On Wed, 2020-02-12 at 14:30 -0800, Tushar Sugandhi wrote:
>
> On 2020-02-12 6:47 a.m., Mimi Zohar wrote:
> > Hi Tushar,
> >
> > Please remove the period at the end of the Subject line.
> Thanks. I will fix it in the next iteration.
> >
> > On Tue, 2020-02-11 at 15:14 -0800, Tushar Sugandhi wrote:
> >> process_buffer_measurement() does not have log messages for failure
> >> conditions.
> >>
> >> This change adds a log statement in the above function.
> >
> > I agree some form of notification needs to be added. The question is
> > whether the failure should be audited or a kernel message emitted.
> > IMA emits audit messages (integrity_audit_msg) for a number of
> > reasons - on failure to calculate a file hash, invalid policy rules,
> > failure to communicate with the TPM, signature verification errors,
> > etc.
> I believe both IMA audit messages and kernel message should be emitted -
> for better discoverability and diagnosability.
Like file measurement failures, failure to measure a key or the boot
command line should be audited as well. For debugging purposes, you
could make this message pr_devel.
Mimi
next prev parent reply other threads:[~2020-02-13 0:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 23:14 [PATCH v3 0/3] IMA: improve log messages in IMA Tushar Sugandhi
2020-02-11 23:14 ` [PATCH v3 1/3] IMA: Update KBUILD_MODNAME for IMA files to ima Tushar Sugandhi
2020-02-12 14:49 ` Mimi Zohar
2020-02-12 22:25 ` Tushar Sugandhi
2020-02-11 23:14 ` [PATCH v3 2/3] IMA: Add log statements for failure conditions Tushar Sugandhi
2020-02-12 14:47 ` Mimi Zohar
2020-02-12 22:30 ` Tushar Sugandhi
2020-02-13 0:21 ` Mimi Zohar [this message]
2020-02-13 21:01 ` Tushar Sugandhi
2020-02-11 23:14 ` [PATCH v3 3/3] IMA: Add module name and base name prefix to log Tushar Sugandhi
2020-02-12 14:29 ` Mimi Zohar
2020-02-12 15:26 ` James Bottomley
2020-02-12 15:47 ` Joe Perches
2020-02-12 22:52 ` Shuah Khan
2020-02-13 0:38 ` Mimi Zohar
2020-02-13 0:56 ` Tushar Sugandhi
2020-02-12 15:23 ` [PATCH v3 0/3] IMA: improve log messages in IMA Mimi Zohar
2020-02-12 22:22 ` Tushar Sugandhi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1581553311.8515.96.camel@linux.ibm.com \
--to=zohar@linux.ibm.com \
--cc=joe@perches.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nramas@linux.microsoft.com \
--cc=sashal@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=tusharsu@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).