Linux-Integrity Archive on lore.kernel.org
 help / color / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Jerry Snitselaar <jsnitsel@redhat.com>
Cc: Alex Guzman <alex@guzman.io>, linux-integrity@vger.kernel.org
Subject: Re: Debugging errors with Dell XPS 9560 TPM
Date: Fri, 14 Feb 2020 16:04:33 -0500
Message-ID: <1581714273.16860.18.camel@HansenPartnership.com> (raw)
In-Reply-To: <20200214210203.dgzhkrvagiozezfi@cantor>

On Fri, 2020-02-14 at 14:02 -0700, Jerry Snitselaar wrote:
> On Fri Feb 14 20, James Bottomley wrote:
> > On Fri, 2020-02-14 at 10:32 -0800, Alex Guzman wrote:
> > > Looks like someone had a look on the bug tracker
> > > (https://bugzilla.kernel.org/show_bug.cgi?id=206275#c6)
> > > and they figure it's definitely a regression in the kernel and
> > > should
> > > be reverted or rectified. They advised me to come ping here once
> > > more.
> > 
> > Reading the bugzilla, I don't get *what* needs to be reverted.  The
> > commit 4d6ebc4c4950595414722dfadd0b361f5a05d37e isn't present in
> > upstream, so what kernel is it present in, or what is the full
> > commit message so we can find the upstream commit?
> > 
> > James
> > 
> > 
> > > - Alex
> > > 
> > > On Sat, Feb 1, 2020 at 4:19 PM Alex Guzman <alex@guzman.io>
> > > wrote:
> > > > 
> > > > Hey there! I reported a bug on the bug tracker a bit ago but
> > > > haven't seen any movement, so I figured I'd drop in here. My
> > > > XPS 9560 has been having issues with its TPM, and all commands
> > > > will fail with error 1 when operating on the TPM device. I
> > > > managed to bisect it back to commit
> > > > 4d6ebc4c4950595414722dfadd0b361f5a05d37e (tpm: fix
> > > > invalid locking in NONBLOCKING mode) though it began failing
> > > > with error 14 (bad address) at that point.
> > > > 
> > > > I reported the bug at
> > > > https://bugzilla.kernel.org/show_bug.cgi?id=206275 and attached
> > > > some dmesg logs from boot there. Does anyone have any
> > > > suggestions for additional debugging or such to figure out
> > > > what's happening here?
> > > > 
> > > > - Alex
> > > 
> > > 
> 
> d23d12484307 | 2019-12-17 | tpm: fix invalid locking in NONBLOCKING
> mode (Tadeusz Struk)
> 
> There is a commit that is a fix to this commit:
> 
> a430e67d9a2c | 2020-01-08 | tpm: Handle negative priv->response_len
> in tpm_common_read() (Tadeusz Struk)

Yes, I suspected it might be that ... in which case upstream should
have the fix, can we verify that 5.6-rc1 works just fine?

James


  reply index

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-02  0:19 Alex Guzman
2020-02-14 18:32 ` Alex Guzman
2020-02-14 20:29   ` James Bottomley
2020-02-14 21:02     ` Jerry Snitselaar
2020-02-14 21:04       ` James Bottomley [this message]
2020-02-15  1:47         ` Alex Guzman
2020-02-18 17:52           ` Tadeusz Struk
2020-02-19 20:32             ` Alex Guzman
2020-02-18 17:52           ` Tadeusz Struk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1581714273.16860.18.camel@HansenPartnership.com \
    --to=james.bottomley@hansenpartnership.com \
    --cc=alex@guzman.io \
    --cc=jsnitsel@redhat.com \
    --cc=linux-integrity@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Integrity Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-integrity/0 linux-integrity/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-integrity linux-integrity/ https://lore.kernel.org/linux-integrity \
		linux-integrity@vger.kernel.org
	public-inbox-index linux-integrity

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-integrity


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git