Linux-Integrity Archive on lore.kernel.org
 help / color / Atom feed
From: Mimi Zohar <zohar@linux.ibm.com>
To: Tushar Sugandhi <tusharsu@linux.microsoft.com>,
	joe@perches.com, skhan@linuxfoundation.org,
	linux-integrity@vger.kernel.org
Cc: sashal@kernel.org, nramas@linux.microsoft.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/3] IMA: Update KBUILD_MODNAME for IMA files to ima
Date: Tue, 18 Feb 2020 14:37:42 -0500
Message-ID: <1582054662.5067.15.camel@linux.ibm.com> (raw)
In-Reply-To: <857c8dc6-d09c-423e-c520-53bb85c6d46c@linux.microsoft.com>

On Tue, 2020-02-18 at 11:25 -0800, Tushar Sugandhi wrote:
> Hi Mimi,
> 
> On 2020-02-14 5:47 p.m., Tushar Sugandhi wrote:
> > The kbuild Makefile specifies object files for vmlinux in the $(obj-y)
> > lists. These lists depend on the kernel configuration[1].
> > 
> > The kbuild Makefile for IMA combines the object files for IMA into a
> > single object file namely ima.o. All the object files for IMA should be
> > combined into ima.o. But certain object files are being added to their
> > own $(obj-y). This results in the log messages from those modules getting
> > prefixed with their respective base file name, instead of "ima". This is
> > inconsistent with the log messages from the IMA modules that are combined
> > into ima.o.
> > 
> > This change fixes the above issue.
> > 
> > [1] Documentation\kbuild\makefiles.rst
> > 
> Is there any feedback on this patch description?
> I can address it in the next iteration.

No, it looks good to me.

Mimi


  reply index

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-15  1:47 [PATCH v4 0/3] IMA: improve log messages Tushar Sugandhi
2020-02-15  1:47 ` [PATCH v4 1/3] IMA: Update KBUILD_MODNAME for IMA files to ima Tushar Sugandhi
2020-02-18 19:25   ` Tushar Sugandhi
2020-02-18 19:37     ` Mimi Zohar [this message]
2020-02-15  1:47 ` [PATCH v4 2/3] IMA: Add log statements for failure conditions Tushar Sugandhi
2020-02-16 12:42   ` Mimi Zohar
2020-02-15  1:47 ` [PATCH v4 3/3] IMA: Remove duplicate pr_fmt definitions Tushar Sugandhi
2020-02-16 12:40   ` Mimi Zohar
2020-02-16 12:40 ` [PATCH v4 0/3] IMA: improve log messages Mimi Zohar
2020-02-18 19:15   ` Tushar Sugandhi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1582054662.5067.15.camel@linux.ibm.com \
    --to=zohar@linux.ibm.com \
    --cc=joe@perches.com \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nramas@linux.microsoft.com \
    --cc=sashal@kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=tusharsu@linux.microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Integrity Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-integrity/0 linux-integrity/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-integrity linux-integrity/ https://lore.kernel.org/linux-integrity \
		linux-integrity@vger.kernel.org
	public-inbox-index linux-integrity

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-integrity


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git